-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements and fixes to docs, badges, readme, etc. #43
Conversation
- fix version in usage - fix badges links - Add License with Contribution section - add `fn main` to example
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=======================================
Coverage 87.13% 87.13%
=======================================
Files 15 15
Lines 1213 1213
=======================================
Hits 1057 1057
Misses 156 156
Continue to review full report at Codecov.
|
/// ### Transit | ||
/// | ||
/// - [`SentenceType::GXA`] | ||
/// - `SentenceType::RTF` (missing?!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dushistov @hargoniX seems like this type is missing from the Enum.
Can you point me in the right direction here - should we add it to the Enum or it's not implemented?
Cargo.toml
Outdated
@@ -8,12 +8,16 @@ authors = [ | |||
] | |||
description = "Simple NMEA 0183 parser" | |||
license = "Apache-2.0" | |||
keywords = ["NMEA", "gps", "glonass", "coordinate", "position"] | |||
keywords = ["NMEA", "gps", "glonass", "coordinate", "position", "galileo", "gnss"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I know crates.io can have 5 keywords maximum ?
rust-lang/cargo#2098
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh.. yes, I completely forgot about that... Will remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. I also added a category.
Can you think of a category addition to crates.io that best fits the NMEA crate? I guess it could be something like Marine electronics
or just Marine
- crates.io allows only 5 keyswords - add `parser-implementations` category
No description provided.