Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and fixes to docs, badges, readme, etc. #43

Merged
merged 7 commits into from
Jul 16, 2022

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Jul 16, 2022

No description provided.

elpiel added 4 commits July 16, 2022 11:42
- fix version in usage
- fix badges links
- Add License with Contribution section
- add `fn main` to example
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #43 (ee7b77f) into master (4dc7598) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files          15       15           
  Lines        1213     1213           
=======================================
  Hits         1057     1057           
  Misses        156      156           
Impacted Files Coverage Δ
src/lib.rs 78.41% <ø> (ø)
src/parse.rs 61.76% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc7598...ee7b77f. Read the comment docs.

This was referenced Jul 16, 2022
/// ### Transit
///
/// - [`SentenceType::GXA`]
/// - `SentenceType::RTF` (missing?!)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dushistov @hargoniX seems like this type is missing from the Enum.
Can you point me in the right direction here - should we add it to the Enum or it's not implemented?

Cargo.toml Outdated
@@ -8,12 +8,16 @@ authors = [
]
description = "Simple NMEA 0183 parser"
license = "Apache-2.0"
keywords = ["NMEA", "gps", "glonass", "coordinate", "position"]
keywords = ["NMEA", "gps", "glonass", "coordinate", "position", "galileo", "gnss"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I know crates.io can have 5 keywords maximum ?
rust-lang/cargo#2098

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh.. yes, I completely forgot about that... Will remove them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. I also added a category.
Can you think of a category addition to crates.io that best fits the NMEA crate? I guess it could be something like Marine electronics or just Marine

src/lib.rs Outdated Show resolved Hide resolved
- crates.io allows only 5 keyswords
- add `parser-implementations` category
@elpiel elpiel requested a review from Dushistov July 16, 2022 12:07
@Dushistov Dushistov merged commit 3da091f into master Jul 16, 2022
@Dushistov Dushistov deleted the improvements-and-fixes branch July 16, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants