Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only fetch the master branch of the registry index #4016

Closed
alexcrichton opened this issue May 9, 2017 · 6 comments · Fixed by #4024
Closed

Only fetch the master branch of the registry index #4016

alexcrichton opened this issue May 9, 2017 · 6 comments · Fixed by #4024
Labels
E-easy Experience: Easy

Comments

@alexcrichton
Copy link
Member

Right now Cargo clones all branches of the index today when it updates. There's only one branch so this isn't so bad but we may one day add more branches.

Let's update the refspec we fetch and only fetch the master branch.
@alexcrichton
Copy link
Member Author

I believe this should be easy enough to implement, so I'm going to tag as E-easy. If anyone would like any assistance though with this please let me know!

@alexcrichton alexcrichton added the E-easy Experience: Easy label May 9, 2017
@alexcrichton
Copy link
Member Author

I've got this implemented locally in a branch that also implements #4015

@rsertelon
Copy link
Contributor

Oh, I was just pushing this for a PR ;)

rsertelon added a commit to rsertelon/cargo that referenced this issue May 10, 2017
@rsertelon
Fetch only master branch of the registry index
dd1fd16 
Should close rust-lang#4016
@alexcrichton
Copy link
Member Author

Oh sorry about that @rsertelon! If you want to send a PR though it may take me a bit to collect the data to justify the one I'm writing, no harm in having two!

@rsertelon
Copy link
Contributor

Should I proceed or not? Given that this is not so much of a big change ^^ (t'was my first attempt at contributing to rust :))

@rsertelon
Copy link
Contributor

ok, moving forward with my PR then!

This was referenced May 10, 2017
Merged
Closed
bors added a commit that referenced this issue May 10, 2017
@bors
Auto merge of #4024 - rsertelon:fix-4016-fetch-only-master, r=alexcri…
58fe1a8 
…chton

Fetch only master branch of the registry index

Should close #4016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Experience: Easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fetch only master branch of the registry index rsertelon/cargo
2 participants
@alexcrichton @rsertelon