Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo test accepts conflicting test flags #5054

Closed
casey opened this issue Feb 19, 2018 · 1 comment · Fixed by #6037
Closed

cargo test accepts conflicting test flags #5054

casey opened this issue Feb 19, 2018 · 1 comment · Fixed by #6037
Assignees

Comments

@casey
Copy link
Contributor

casey commented Feb 19, 2018

cargo test accepts multiple flags that specify which tests to run, but will only honor one of them. For example, cargo test --lib --doc seems to only run the doc tests.

I ran into an issue where cargo test was invoked with --lib --doc on Travis, with the intent of running both library and documentation tests, but library tests were skipped, leading to an accidental gap in CI test coverage.

I would suggest that both flags be honored, but just returning an error for conflicting flags also seems reasonable.

@stale
Copy link

stale bot commented Sep 16, 2018

As there hasn't been any activity here in over 6 months I've marked this as stale and if no further activity happens for 7 days I will close it.

I'm a bot so this may be in error! If this issue should remain open, could someone (the author, a team member, or any interested party) please comment to that effect?

The team would be especially grateful if such a comment included details such as:

  • Is this still relevant?
  • If so, what is blocking it?
  • Is it known what could be done to help move this forward?

Thank you for contributing!

If you're reading this comment from the distant future, fear not if this was closed automatically. If you believe it's still an issue please leave a comment and a team member can reopen this issue. Opening a new issue is also acceptable!

@stale stale bot added the stale label Sep 16, 2018
@dwijnand dwijnand self-assigned this Sep 16, 2018
@stale stale bot removed the stale label Sep 16, 2018
bors added a commit that referenced this issue Sep 17, 2018
…rget-options, r=alexcrichton

Stop test --doc from silently ignoring other target selecting options

Fixes #5054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants