Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUSTC_WRAPPER= should use no wrapper instead of attempting to run the command "" #5588

Closed
Hello71 opened this issue May 28, 2018 · 0 comments · Fixed by #5985
Closed

RUSTC_WRAPPER= should use no wrapper instead of attempting to run the command "" #5588

Hello71 opened this issue May 28, 2018 · 0 comments · Fixed by #5985
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`

Comments

@Hello71
Copy link

Hello71 commented May 28, 2018

rationale: it is easier to write RUSTC_WRAPPER= cargo build than (unset RUSTC_WRAPPER; cargo build), and invoking "" is never a useful thing to do.
@alexcrichton alexcrichton added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label May 28, 2018
@dwijnand dwijnand mentioned this issue Sep 5, 2018
Merged
bors added a commit that referenced this issue Sep 6, 2018
@bors
Auto merge of #5985 - dwijnand:fix-rustc-wrapper-unset, r=alexcrichton
7afa449 
Don't use an empty RUSTC_WRAPPER

Fixes #5588
@bors bors closed this as completed in #5985 Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use an empty RUSTC_WRAPPER dwijnand/cargo
2 participants
@alexcrichton @Hello71