Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI nit: Progress bar partially overwritten by errors #5764

Closed
mark-i-m opened this issue Jul 22, 2018 · 1 comment · Fixed by #5862
Closed

UI nit: Progress bar partially overwritten by errors #5764

mark-i-m opened this issue Jul 22, 2018 · 1 comment · Fixed by #5862

Comments

@mark-i-m
Copy link
Member

cc #3448, #2536

When compilation terminates with an error, the progress bar is partially overwritten. Perhaps there is a missing \n that needs to be output before the first error?

Sample error:

$ cargo +nightly check
    Checking x86_64 v0.2.4 (file:///home/mark/Documents/home/x86_64)                                                                                                                                                
error[E0573]: expected type, found module `self`==============>          ] 5/6: x86_64                                                                                                                              
   --> src/structures/paging/recursive.rs:354:14
    |
354 |         &mut self,
    |              ^^^^ did you mean `Self`?

Notice this part: ==============> ] 5/6: x86_64. This is the progress bar (I'm compiling the x86_64 crate), which is overwritten by the first error.

$ cargo --version
cargo 1.27.0 (1e95190e5 2018-05-27)
@alexcrichton
Copy link
Member

Thanks for the report! This has been fixed in Cargo for a bit now and thankfully we just got a nightly with the fix out, so we should be good to go!

bors added a commit that referenced this issue Aug 6, 2018
Fully capture rustc and rustdoc output when -Zcompile-progress is passed

Fixes #5764 and #5695.

On Windows, we will parse the ANSI escape code into console commands via my `fwdansi` package, based on @ishitatsuyuki's idea in #5695 (comment). Outside of Windows the content is forwarded as-is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants