Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo fix doesn't work with RUSTC_WRAPPER=sccache #5981

Closed
dwijnand opened this issue Sep 5, 2018 · 1 comment · Fixed by #5983
Closed

cargo fix doesn't work with RUSTC_WRAPPER=sccache #5981

dwijnand opened this issue Sep 5, 2018 · 1 comment · Fixed by #5983
Labels
Command-fix

Comments

@dwijnand
Copy link
Member

dwijnand commented Sep 5, 2018

Before:

$ cargo +nightly new --lib foo && command cd foo && cargo +nightly fix --lib
     Created library `foo` project
    Checking foo v0.1.0 (file:///Users/dnw/Desktop/foo)
error: failed to execute compile
caused by: Bad relative path
error: Could not compile `foo`.

After:

$ unset RUSTC_WRAPPER; cargo +nightly new --lib foo && command cd foo && cargo +nightly fix --lib
     Created library `foo` project
    Checking foo v0.1.0 (file:///Users/dnw/Desktop/foo)
    Finished dev [unoptimized + debuginfo] target(s) in 0.82s
@alexcrichton
Copy link
Member

Oh dear sounds bad! I think for cargo fix this is basically incompatible right now, so we should probably just forcibly disable handling of RUSTC_WRAPPER

alexcrichton added a commit to alexcrichton/cargo that referenced this issue Sep 5, 2018
@alexcrichton
fix: Fix unusual errors with RUSTC_WRAPPER
51be742 
This commit fixes the interaction of `cargo fix` and `RUSTC_WRAPPER`, ensuring
that Cargo at least doesn't die internally. For now `RUSTC_WRAPPER` is
overridden for normal execution but we can eventually one day probably support
`RUSTC_WRAPPER`!

Closes rust-lang#5981
@alexcrichton alexcrichton mentioned this issue Sep 5, 2018
Merged
bors added a commit that referenced this issue Sep 6, 2018
@bors
Auto merge of #5983 - alexcrichton:fix-rustc-wrapper, r=dwijnand
b15ee25 
fix: Fix unusual errors with `RUSTC_WRAPPER`

This commit fixes the interaction of `cargo fix` and `RUSTC_WRAPPER`, ensuring
that Cargo at least doesn't die internally. For now `RUSTC_WRAPPER` is
overridden for normal execution but we can eventually one day probably support
`RUSTC_WRAPPER`!

Closes #5981
@bors bors closed this as completed in #5983 Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Command-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix unusual errors with RUSTC_WRAPPER alexcrichton/cargo
2 participants
@alexcrichton @dwijnand