Aliasing of build.rs output when --out-dir is used

[idubrov]

Problem

Unstable flag --out-dir is unsafe in presence of multiple packages with build scripts & parallel build.

What I think is happening is with flag --out-dir cargo places compiled build.rs in a same location for all packages. For example, if I set --out-dir=./target, all build scripts will be compiled into target/build-script-build.

In case of a parallel build, this causes race condition between multiple processes. Eventually, build fails, either because script is deleted by another process or when wrong script is executed.

When build scripts do things like setting extra rustc arguments or generate files, build fails in a particularly spectacular way.

As an example, this is what we periodically get on our CI:

error[E0277]: the trait bound `i128: traits::Num` is not satisfied
   --> /usr/local/cargo/registry/src/git.luolix.top-1ecc6299db9ec823/num-integer-0.1.39/src/roots.rs:136:14
    |
136 |         impl Roots for $T {
    |              ^^^^^ the trait `traits::Num` is not implemented for `i128`
...
170 | signed_roots!(i128, u128);
    | -------------------------- in this macro invocation

I think, this happens because num-traits uses build.rs to set has_i128. So, if "wrong" build.rs is being executed, package does not get this flag and eventually its dependency num-integer fails because of an error above (because it sets this flag independently).

Steps

1. Get sample project from https://github.com/idubrov/cargo-out-dir-bug
2. This project is nothing more than a 100 empty modules with build.rs files.
3. Run cargo build -- everything works fine
4. Run cargo -Z unstable-options build --out-dir=./target
5. Eventually, build fails with:

error: failed to remove file `/Users/idubrov/Projects/outdir/./target/build-script-build`                                                                                                                                                     

Caused by:
  No such file or directory (os error 2)

Possible Solution(s)

Maybe, treat build.rs output specially from regular outputs? Never place it into the directory specified by --out-dir?

Notes

Output of cargo version:

$ cargo version
cargo 1.31.0-nightly (2d0863f65 2018-10-20)

[idubrov]

I guess it is similar to #6293 except that you don't really have control over target name and also build.rs usage is very common.