Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic switching a dependency location from crates.io to git #951

Closed
sfackler opened this issue Nov 22, 2014 · 3 comments · Fixed by #965
Closed

Panic switching a dependency location from crates.io to git #951

sfackler opened this issue Nov 22, 2014 · 3 comments · Fixed by #965

Comments

@sfackler
Copy link
Member

I switched my dependency on time to cargo, and then back to git and ran into this.

    Updating git repository `https://github.com/rust-lang/time`
task '<main>' panicked at 'assertion failed: `(left == right) && (right == left)` (left: `registry https://github.com/rust-lang/crates.io-index`, right: `https://github.com/alexcrichton/gcc-rs#f25b3ba9`)', src/cargo/core/dependency.rs:130
stack backtrace:
   1:     0x7f741de011f0 - rt::backtrace::imp::write::h81c9e341ae049cf36Ss
   2:     0x7f741de04080 - failure::on_fail::ha3f380e7155b836eTet
   3:     0x7f741de1fa40 - unwind::begin_unwind_inner::h3706a70df18fbd51Pad
   4:     0x7f741de1f6c0 - unwind::begin_unwind_fmt::h1b865acae8257a39h8c
   5:     0x7f741d954290 - core::dependency::Dependency::lock_to::hec8f179e2eb5c01eihc
   6:     0x7f741d98c7b0 - core::registry::PackageRegistry<'a>::lock::closure.21411
   7:     0x7f741d976ce0 - core::summary::Summary::map_dependencies::h0cd63e9d460ddc9cz0f
   8:     0x7f741d98bec0 - core::registry::PackageRegistry<'a>::lock::h10840f960757cf6ciDg
   9:     0x7f741d98ccb0 - core::registry::PackageRegistry<'a>.Registry::query::h931d28b6f1ec7872iGg
  10:     0x7f741daa89e0 - core::resolver::activate::closure.26794
  11:     0x7f741daa6fd0 - core::resolver::activate::h14492787186743145269
  12:     0x7f741d9af280 - ops::resolve::resolve_with_previous::h2a25093fe598644bevo
  13:     0x7f741d9ae970 - ops::resolve::resolve_pkg::hd64baffaf7bdd80eMto
  14:     0x7f741d9a48b0 - ops::cargo_compile::compile_pkg::hcfe461b9fc6965081kh
  15:     0x7f741d9a37b0 - ops::cargo_compile::compile::h6196a35746101439Zfh
  16:     0x7f741da78f20 - ops::cargo_test::run_tests::hed9432a6c0abdc2cTrn
  17:     0x7f741d918c70 - call_main_without_stdin::h4246790084339011829
  18:     0x7f741d8e0430 - execute::h39031d81b150e80cfda
  19:     0x7f741d8dbe60 - call_main_without_stdin::h8312179330156443248
  20:     0x7f741d8da780 - main::h35e31721c44500bc6ca
  21:     0x7f741d932350 - start::closure.2710
  22:     0x7f741de205c0 - rust_try_inner
  23:     0x7f741de205b0 - rust_try
  24:     0x7f741de1db80 - unwind::try::h377a7258facecb9brZc
  25:     0x7f741de1da20 - task::Task::run::hfe1b5334ddefb0cdh5b
  26:     0x7f741d932050 - start::h9c6838dcadf5c15e1ma
  27:     0x7f741d931fc0 - lang_start::h9a844e234c7fe5a9kma
  28:     0x7f741c876f50 - __libc_start_main
  29:                0x0 - <unknown>
@alexcrichton
Copy link
Member

Yes I've seen this from time to time as well, I shall investigate!

@sfackler
Copy link
Member Author

Deleting Cargo.lock fixed it, fyi.

alexcrichton added a commit to alexcrichton/cargo that referenced this issue Nov 24, 2014
@alexcrichton
Test source equality when locking dependencies
2ba5c5e 
When applying the lockfile to a resolve graph, we need to take into account that
the listed source of dependencies can change over time, in which case we cannot
lock to the previous version but instead need to continue onwards with updating
the listed source.

Closes rust-lang#951
@alexcrichton alexcrichton mentioned this issue Nov 24, 2014
Merged
@alexcrichton
Copy link
Member

Fixed in #965

bors added a commit that referenced this issue Nov 25, 2014
@bors
auto merge of #965 : alexcrichton/cargo/issue-951, r=brson
b9ff1a3 
When applying the lockfile to a resolve graph, we need to take into account that
the listed source of dependencies can change over time, in which case we cannot
lock to the previous version but instead need to continue onwards with updating
the listed source.

Closes #951
@bors bors closed this as completed in #965 Nov 25, 2014
@alexcrichton alexcrichton mentioned this issue Nov 27, 2014
Merged
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Nov 27, 2014
@alexcrichton
Handle updates to version requirements in lockfiles
493d310 
This is the same as the fix for rust-lang#951 (fixed by rust-lang#965). The relevant code was
erroneously looking at the source id when it should instead look at the entire
package id (name/version/source).
bors added a commit that referenced this issue Dec 4, 2014
@bors
auto merge of #990 : alexcrichton/cargo/update-blows-up, r=brson
4353abb 
This is the same as the fix for #951 (fixed by #965). The relevant code was
erroneously looking at the source id when it should instead look at the entire
package id (name/version/source).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test source equality when locking dependencies alexcrichton/cargo
2 participants
@alexcrichton @sfackler