Chore: prefer HashMap::from rather than collecting Vec of tuples
#10018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 144d941 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 2, 2021
Update cargo 3 commits in 6c1bc24b8b49d4bc965f67d7037906dc199c72b7..94ca096afbf25f670e76e07dca754fcfe27134be 2021-10-24 17:51:41 +0000 to 2021-10-29 14:45:06 +0000 - Chore: prefer `HashMap::from` rather than collecting `Vec` of tuples (rust-lang/cargo#10018) - Change --scrape-examples flag to -Z rustdoc-scrape-examples (rust-lang/cargo#10017) - Scrape code examples from examples/ directory for Rustdoc (rust-lang/cargo#9525)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there! Since Cargo upgraded to the 2021 Edition recently (which implies a
rust-versionof1.56or greater), I figured now may be a good time to use the newHashMap::fromshortcut of rust-lang/rust#84111. There should be no change in behavior here, but it does make the code a little bit neater! 🎉