Fix a couple issues with cyclic features and dev-dependencies #10103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a convoluted situation where a cyclic dev-dependency attempts to enable a feature on its parent. It would result in a confusing error saying a package didn't have a feature. This check was intended only for CLI features, not features passed through the dependency graph.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 2eee644 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 22, 2021
Update cargo 7 commits in ad50d0d266213e0cc4f6e526a39d96faae9a3842..e1fb17631eb1b3665cdbe45b1c186111577ef512 2021-11-17 18:36:37 +0000 to 2021-11-22 16:53:06 +0000 - re-enable lto_build test on 32-bit MSVC (rust-lang/cargo#10110) - Fix a couple issues with cyclic features and dev-dependencies (rust-lang/cargo#10103) - Add --message-format for install command (rust-lang/cargo#10107) - Update curl dependency, remove M1 macOS build error note (rust-lang/cargo#10106) - Make clippy happy (rust-lang/cargo#10105) - Give a hard error if `-Zrustdoc-scrape-examples` is missing a flag (rust-lang/cargo#10043) - silly fix, pointer to the empty slice (rust-lang/cargo#10097)
This was referenced Nov 1, 2023
bors
added a commit
that referenced
this pull request
Nov 1, 2023
Add regression test for issue 6915: features and transitive dev deps Closes #6915. That issue was fixed without realizing by #10103. In search of test coverage, I looked through `rg '[a-z0-9_-]+ = \["[a-z0-9_-]+/[a-z0-9_-]+"\]' tests/testsuite/` and did not find any existing test that exercises this situation. The tests added by #10103 are focused on cycles and `cargo tree`, which is substantially different from #6915. Tested by `cargo test --test testsuite -- features::activating_feature_does_not_activate_transitive_dev_dependency`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues with cyclic features and dev-dependencies:
cargo treewould enter an infinite loop for cyclic features.Fixes #10101