Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make levenshtein distance case insensitive. #10224

Merged
merged 2 commits into from
Dec 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/cargo/util/lev_distance.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
use std::cmp;

pub fn lev_distance(me: &str, t: &str) -> usize {
// Comparing the strings lowercased will result in a difference in capitalization being less distance away
// than being a completely different letter. Otherwise `CHECK` is as far away from `check` as it
// is from `build` (both with a distance of 5). For a single letter shortcut (e.g. `b` or `c`), they will
// all be as far away from any capital single letter entry (all with a distance of 1).
// By first lowercasing the strings, `C` and `c` are closer than `C` and `b`, for example.
let me = me.to_lowercase();
let t = t.to_lowercase();

let t_len = t.chars().count();
if me.is_empty() {
return t_len;
Expand Down
28 changes: 28 additions & 0 deletions tests/testsuite/cargo_command.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,34 @@ fn list_command_resolves_symlinks() {
);
}

#[cargo_test]
fn find_closest_capital_c_to_c() {
cargo_process("C")
.with_status(101)
.with_stderr_contains(
"\
error: no such subcommand: `C`

<tab>Did you mean `c`?
",
)
.run();
}

#[cargo_test]
fn find_closest_captial_b_to_b() {
cargo_process("B")
.with_status(101)
.with_stderr_contains(
"\
error: no such subcommand: `B`

<tab>Did you mean `b`?
",
)
.run();
}

#[cargo_test]
fn find_closest_biuld_to_build() {
cargo_process("biuld")
Expand Down