Refactor git rev handling infrastructure #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit unifies the notion of a "git revision" between a SourceId and the GitSource. This pushes the request of a branch, tag, or revision all the way down into a GitSource so special care can be taken for each case. This primarily was discovered by rust-lang#1069 where a git tag's id is different from the commit that it points at, and we need to push the knowledge of whether it's a tag or not all the way down to the point where we resolve what revision we want (and perform appropriate operations to find the commit we want). Closes rust-lang#1069
alexcrichton
force-pushed
the
issue-1069
branch
from
1ce19a0
to
aa256ff
Compare
bors
added a commit
that referenced
this pull request
Dec 30, 2014
This commit unifies the notion of a "git revision" between a SourceId and the GitSource. This pushes the request of a branch, tag, or revision all the way down into a GitSource so special care can be taken for each case. This primarily was discovered by #1069 where a git tag's id is different from the commit that it points at, and we need to push the knowledge of whether it's a tag or not all the way down to the point where we resolve what revision we want (and perform appropriate operations to find the commit we want). Closes #1069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit unifies the notion of a "git revision" between a SourceId and the
GitSource. This pushes the request of a branch, tag, or revision all the way
down into a GitSource so special care can be taken for each case.
This primarily was discovered by #1069 where a git tag's id is different from
the commit that it points at, and we need to push the knowledge of whether it's
a tag or not all the way down to the point where we resolve what revision we
want (and perform appropriate operations to find the commit we want).
Closes #1069