doc(cargo-tree): mention it considering feature unification #11282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
epage
reviewed
Oct 24, 2022
src/doc/man/cargo-tree.md
Outdated
Comment on lines
58
to
60
| This command takes feature unifications into account. That is to say, the | ||
| command shows a graph much closer to a feature-unified graph Cargo will build, | ||
| rather than what you list in `Cargo.toml`. For instance, if you have the same |
There was a problem hiding this comment.
For most people, I feel like the two leading sentences will lose people as they are speaking in cargo jargon.
Maybe just lead with "This command shows a graph much closer to a feature-unified graph that Cargo will build than what you list in Cargo.toml. ..." That gives people more upfront context so hopefully they don't get lost as much.
There was a problem hiding this comment.
Fantastic advice! I'll keep in mind we're writing a guide for users, not contributors.
Updated with 4a76339. Thank you!
weihanglo
force-pushed
the
doc/cargo-tree
branch
from
32e10cc
to
5b048c6
Compare
weihanglo
force-pushed
the
doc/cargo-tree
branch
from
5b048c6
to
4a76339
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
compiler-errors
pushed a commit
to compiler-errors/rust
that referenced
this pull request
Oct 26, 2022
5 commits in 071eeaf210708219a5a1b2c4728ca2f97df7f2ae..9210810d1fd7b51ae0439a0a363cc50e36963455 2022-10-22 01:17:55 +0000 to 2022-10-25 22:31:50 +0000 - Fix 410 gone response handling (rust-lang/cargo#11286) - Fix inequality in "stale mtime" log messages (rust-lang/cargo#11281) - doc(cargo-tree): mention it considering feature unification (rust-lang/cargo#11282) - Improve the error message if `publish` is `false` or empty list (rust-lang/cargo#11280) - Add test for deleted index entry (rust-lang/cargo#11278)
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Oct 26, 2022
Update cargo 5 commits in 071eeaf210708219a5a1b2c4728ca2f97df7f2ae..9210810d1fd7b51ae0439a0a363cc50e36963455 2022-10-22 01:17:55 +0000 to 2022-10-25 22:31:50 +0000 - Fix 410 gone response handling (rust-lang/cargo#11286) - Fix inequality in "stale mtime" log messages (rust-lang/cargo#11281) - doc(cargo-tree): mention it considering feature unification (rust-lang/cargo#11282) - Improve the error message if `publish` is `false` or empty list (rust-lang/cargo#11280) - Add test for deleted index entry (rust-lang/cargo#11278)
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Oct 26, 2022
Update cargo 5 commits in 071eeaf210708219a5a1b2c4728ca2f97df7f2ae..9210810d1fd7b51ae0439a0a363cc50e36963455 2022-10-22 01:17:55 +0000 to 2022-10-25 22:31:50 +0000 - Fix 410 gone response handling (rust-lang/cargo#11286) - Fix inequality in "stale mtime" log messages (rust-lang/cargo#11281) - doc(cargo-tree): mention it considering feature unification (rust-lang/cargo#11282) - Improve the error message if `publish` is `false` or empty list (rust-lang/cargo#11280) - Add test for deleted index entry (rust-lang/cargo#11278)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Mention that
cargo treetakes feature unification into account.Most the contents come from #11261 (comment) and #11261 (comment).
Fixes #11261
How should we test and review this PR?
Checkout man page:
Checkout the book:
I am trying to slim down the amount added. If you have any suggestion to reduce the amount please share it.