-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support codegen-backend
and rustflags
in profiles in config file
#11562
Conversation
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
Thanks! Can you also update |
86dee1b
to
5c87110
Compare
Thanks! @bors r+ |
☀️ Test successful - checks-actions |
9 commits in 1cd6d3803dfb0b342272862a8590f5dfc9f72573..a5d47a72595dd6fbe7d4e4f6ec20dc5fe724edd1 2023-01-12 18:40:36 +0000 to 2023-01-16 18:51:50 +0000 - Add network container tests (rust-lang/cargo#11583) - Show progress of crates.io index update even `net.git-fetch-with-cli` option enabled (rust-lang/cargo#11579) - `cargo metadata` supports artifact dependencies (rust-lang/cargo#11550) - fix(docs): add required "inherits" option to example profile (rust-lang/cargo#11504) - add documentation that SSH markers aren't supported (rust-lang/cargo#11586) - Fix typo (rust-lang/cargo#11585) - Enable source_config_env test on Windows (rust-lang/cargo#11582) - Support `codegen-backend` and `rustflags` in profiles in config file (rust-lang/cargo#11562) - ci: reflect to clap updates (rust-lang/cargo#11578)
Update cargo 9 commits in 1cd6d3803dfb0b342272862a8590f5dfc9f72573..a5d47a72595dd6fbe7d4e4f6ec20dc5fe724edd1 2023-01-12 18:40:36 +0000 to 2023-01-16 18:51:50 +0000 - Add network container tests (rust-lang/cargo#11583) - Show progress of crates.io index update even `net.git-fetch-with-cli` option enabled (rust-lang/cargo#11579) - `cargo metadata` supports artifact dependencies (rust-lang/cargo#11550) - fix(docs): add required "inherits" option to example profile (rust-lang/cargo#11504) - add documentation that SSH markers aren't supported (rust-lang/cargo#11586) - Fix typo (rust-lang/cargo#11585) - Enable source_config_env test on Windows (rust-lang/cargo#11582) - Support `codegen-backend` and `rustflags` in profiles in config file (rust-lang/cargo#11562) - ci: reflect to clap updates (rust-lang/cargo#11578) r? `@ghost`
How does one use this? I added as per the instruction but it says failed to find the directory. [unstable]
codegen-backend = true
[profile.dev]
codegen-backend = "cranelift" Error
Maybe I need to add it from rustup? |
Hi, @pickfire. This unstable feature just passes the value to rustc cargo/src/cargo/core/compiler/mod.rs Line 1058 in 7bf43f0
There is a pull request rust-lang/rust#81746 making clif a rustupcomponent though. |
What does this PR try to resolve?
Add two
-Z
flagsprofile-rustflags
codegen-backend
to support configuring them in
.cargo/config.toml
without touchingCargo.toml
.How should we test and review this PR?
A test is added for
-Zprofile-rustflags
. There is no test aroundcodegen-backend
. I followed that.Additional information
Was trying to write an instruction for this fix but accidentally finished it…
Fixes #11552
Fixes #9926