Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: autolabel more for A-* #11679

Merged
merged 1 commit into from
Feb 9, 2023
Merged

chore: autolabel more for A-* #11679

merged 1 commit into from
Feb 9, 2023

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

A follow-up of #11664 for most A-* labels. We have a doc here tracking autolabel stuff.

How should we test and review this PR?

All trigger_files fields are based on human knowledge, some labels are hard to determine.
The rule to apply a label on a file: What a file does ⊂ What a label describes.
This is a bit conservative. Shall we be more aggressive? So that it will hurt us and make us know how to improve.

Some files are not included in any of label. Most of them are utilities or types definitions. I think that makes sense not including them at this moment.

@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2023
@weihanglo
Copy link
Member Author

cc @Muscraft

triagebot.toml Outdated Show resolved Hide resolved
triagebot.toml Outdated Show resolved Hide resolved
@epage
Copy link
Contributor

epage commented Feb 4, 2023

I feel like this change does a couple of things

  • Provides a resource to go from topic -> code
  • Helps highlight our current organization for improvement
  • Helps highlight our current tags for improvement

Copy link
Member

@Muscraft Muscraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Do you think we should include the label descriptions above the table? It has helped me classify what should go where a few times. I am not sure it is needed in this PR just something to think about.

triagebot.toml Show resolved Hide resolved
@weihanglo
Copy link
Member Author

Do you think we should include the label descriptions above the table? It has helped me classify what should go where a few times. I am not sure it is needed in this PR just something to think about.

Or maybe we could teach triagebot how to manage labels based on triagebot.toml? That would be way better than syncing them by hand 😆.

@ehuss
Copy link
Contributor

ehuss commented Feb 5, 2023

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 5, 2023

📌 Commit dd067b3 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2023
@bors
Copy link
Contributor

bors commented Feb 5, 2023

⌛ Testing commit dd067b3 with merge f290ec5...

bors added a commit that referenced this pull request Feb 5, 2023
chore: autolabel more for `A-*`

### What does this PR try to resolve?

A follow-up of #11664 for most `A-*` labels. We have a [doc here][hackmd] tracking autolabel stuff.

### How should we test and review this PR?

All `trigger_files` fields are based on human knowledge, some labels are hard to determine.
The rule to apply a label on a file: *What a file does ⊂ What a label describes*.
This is a bit conservative. Shall we be more aggressive? So that it will hurt us and make us know how to improve.

[hackmd]: https://hackmd.io/cNsQWpKyRSWHlgVAIYUFdg

Some files are not included in any of label. Most of them are utilities or types definitions. I think that makes sense not including them at this moment.
@bors
Copy link
Contributor

bors commented Feb 5, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2023
@ehuss
Copy link
Contributor

ehuss commented Feb 6, 2023

CI will be blocked until rust-lang/rust#107688 lands in nightly.

@weihanglo
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2023
@bors
Copy link
Contributor

bors commented Feb 8, 2023

⌛ Testing commit dd067b3 with merge 55e5fb3...

bors added a commit that referenced this pull request Feb 8, 2023
chore: autolabel more for `A-*`

### What does this PR try to resolve?

A follow-up of #11664 for most `A-*` labels. We have a [doc here][hackmd] tracking autolabel stuff.

### How should we test and review this PR?

All `trigger_files` fields are based on human knowledge, some labels are hard to determine.
The rule to apply a label on a file: *What a file does ⊂ What a label describes*.
This is a bit conservative. Shall we be more aggressive? So that it will hurt us and make us know how to improve.

[hackmd]: https://hackmd.io/cNsQWpKyRSWHlgVAIYUFdg

Some files are not included in any of label. Most of them are utilities or types definitions. I think that makes sense not including them at this moment.
@bors
Copy link
Contributor

bors commented Feb 8, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 8, 2023
@weihanglo
Copy link
Member Author

I was wrong. Not yet landed 😅

@ehuss
Copy link
Contributor

ehuss commented Feb 9, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Feb 9, 2023

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Feb 9, 2023

📌 Commit dd067b3 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2023
@bors
Copy link
Contributor

bors commented Feb 9, 2023

⌛ Testing commit dd067b3 with merge 2286d5f...

@bors
Copy link
Contributor

bors commented Feb 9, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 2286d5f to master...

@bors bors merged commit 2286d5f into rust-lang:master Feb 9, 2023
@weihanglo weihanglo deleted the autolabel branch February 9, 2023 06:46
weihanglo added a commit to weihanglo/rust that referenced this pull request Feb 13, 2023
10 commits in 82c3bb79e3a19a5164e33819ef81bfc2c984bc56..39c13e67a5962466cc7253d41bc1099bbcb224c3
2023-02-04 22:52:16 +0000 to 2023-02-12 02:01:08 +0000

- chore: Update to toml v0.6, toml_edit v0.18 (rust-lang/cargo#11618)
- doc: more doc comments and intra-doc links (rust-lang/cargo#11703)
- Deny warnings in CI, not locally (rust-lang/cargo#11699)
- add comment to lto.rs (rust-lang/cargo#11701)
- Re-export cargo_new::NewProjectKind as public (rust-lang/cargo#11700)
- Add '-C' flag for changing current dir before build (rust-lang/cargo#10952)
- `-Zrustdoc-scrape-example` must fail with bad build script (rust-lang/cargo#11694)
- Update CHANGELOG for 1.68 backports (rust-lang/cargo#11690)
- Update 1password to the version 2 CLI (rust-lang/cargo#11692)
- chore: autolabel more for `A-*` (rust-lang/cargo#11679)
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2023
Update cargo

10 commits in 82c3bb79e3a19a5164e33819ef81bfc2c984bc56..39c13e67a5962466cc7253d41bc1099bbcb224c3 2023-02-04 22:52:16 +0000 to 2023-02-12 02:01:08 +0000

- chore: Update to toml v0.6, toml_edit v0.18 (rust-lang/cargo#11618)
- doc: more doc comments and intra-doc links (rust-lang/cargo#11703)
- Deny warnings in CI, not locally (rust-lang/cargo#11699)
- add comment to lto.rs (rust-lang/cargo#11701)
- Re-export cargo_new::NewProjectKind as public (rust-lang/cargo#11700)
- Add '-C' flag for changing current dir before build (rust-lang/cargo#10952)
- `-Zrustdoc-scrape-example` must fail with bad build script (rust-lang/cargo#11694)
- Update CHANGELOG for 1.68 backports (rust-lang/cargo#11690)
- Update 1password to the version 2 CLI (rust-lang/cargo#11692)
- chore: autolabel more for `A-*` (rust-lang/cargo#11679)

r? `@ghost`
@ehuss ehuss added this to the 1.69.0 milestone Mar 9, 2023
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 20, 2024
Update cargo

10 commits in 82c3bb79e3a19a5164e33819ef81bfc2c984bc56..39c13e67a5962466cc7253d41bc1099bbcb224c3 2023-02-04 22:52:16 +0000 to 2023-02-12 02:01:08 +0000

- chore: Update to toml v0.6, toml_edit v0.18 (rust-lang/cargo#11618)
- doc: more doc comments and intra-doc links (rust-lang/cargo#11703)
- Deny warnings in CI, not locally (rust-lang/cargo#11699)
- add comment to lto.rs (rust-lang/cargo#11701)
- Re-export cargo_new::NewProjectKind as public (rust-lang/cargo#11700)
- Add '-C' flag for changing current dir before build (rust-lang/cargo#10952)
- `-Zrustdoc-scrape-example` must fail with bad build script (rust-lang/cargo#11694)
- Update CHANGELOG for 1.68 backports (rust-lang/cargo#11690)
- Update 1password to the version 2 CLI (rust-lang/cargo#11692)
- chore: autolabel more for `A-*` (rust-lang/cargo#11679)

r? `@ghost`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
Update cargo

10 commits in 82c3bb79e3a19a5164e33819ef81bfc2c984bc56..39c13e67a5962466cc7253d41bc1099bbcb224c3 2023-02-04 22:52:16 +0000 to 2023-02-12 02:01:08 +0000

- chore: Update to toml v0.6, toml_edit v0.18 (rust-lang/cargo#11618)
- doc: more doc comments and intra-doc links (rust-lang/cargo#11703)
- Deny warnings in CI, not locally (rust-lang/cargo#11699)
- add comment to lto.rs (rust-lang/cargo#11701)
- Re-export cargo_new::NewProjectKind as public (rust-lang/cargo#11700)
- Add '-C' flag for changing current dir before build (rust-lang/cargo#10952)
- `-Zrustdoc-scrape-example` must fail with bad build script (rust-lang/cargo#11694)
- Update CHANGELOG for 1.68 backports (rust-lang/cargo#11690)
- Update 1password to the version 2 CLI (rust-lang/cargo#11692)
- chore: autolabel more for `A-*` (rust-lang/cargo#11679)

r? `@ghost`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants