Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump crates-io to 0.36.0 #11820

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Bump crates-io to 0.36.0 #11820

merged 1 commit into from
Mar 9, 2023

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Mar 9, 2023 •
edited
Loading

This was an overlook of #11600

Since we already got #11806 to backport, I guess it is not harmful to beta-nominated Nominated to backport to the beta branch. this as well. Maybe it do need a backport as src/cargo/ops/registry.rs use a new public API from that PR.

BTW, please help check if it is really a breaking change.

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-interacts-with-crates.io Area: interaction with registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2023
@epage
Copy link
Contributor

epage commented Mar 9, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2023

📌 Commit 8296cfe has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2023
@ehuss
Copy link
Contributor

ehuss commented Mar 9, 2023

@bors r-

This doesn't look like a semver breaking change. It is only adding a new function, unless I am missing something.

@bors bors added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2023
@ehuss
Copy link
Contributor

ehuss commented Mar 9, 2023

As for a beta backport, I think that will be required for cargo-the-library to not break.

@weihanglo
Copy link
Member Author

This doesn't look like a semver breaking change. It is only adding a new function, unless I am missing something.

In terms of API change, it is no doubt SemVer-compatible. I wonder whether behaviour change is a SemVer breakage. The Registry::req() function now rejects invalid tokens.

@weihanglo weihanglo added the beta-nominated Nominated to backport to the beta branch. label Mar 9, 2023
@ehuss
Copy link
Contributor

ehuss commented Mar 9, 2023

I see. I normally wouldn't be too concerned about that since per our discussion on the original change, the likelihood of this being a problem is close to zero.

However, since I don't think there are really any significant users of crates-io besides cargo itself, then I don't think it hurts too much to burn through version numbers.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2023

📌 Commit 8296cfe has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Mar 9, 2023
@bors
Copy link
Contributor

bors commented Mar 9, 2023

⌛ Testing commit 8296cfe with merge 7c6601b...

bors added a commit that referenced this pull request Mar 9, 2023
@bors
Auto merge of #11820 - weihanglo:bump-crates-io, r=ehuss
7c6601b 
Bump crates-io to 0.36.0

This was an overlook of #11600

Since we already got #11806 to backport, I guess it is not harmful to <https://github.com/rust-lang/cargo/labels/beta-nominated> this as well.  Maybe it do need a backport as `src/cargo/ops/registry.rs` use a new public API from that PR.

BTW, please help check if it is really a breaking change.
@bors
Copy link
Contributor

bors commented Mar 9, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2023
@ehuss ehuss mentioned this pull request Mar 9, 2023
Closed
@ehuss
Copy link
Contributor

ehuss commented Mar 9, 2023

@bors retry

#11821

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2023
@bors
Copy link
Contributor

bors commented Mar 9, 2023

⌛ Testing commit 8296cfe with merge 0dec9a3...

@bors
Copy link
Contributor

bors commented Mar 9, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 0dec9a3 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 9, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 0dec9a3 to master...

@bors bors merged commit 0dec9a3 into rust-lang:master Mar 9, 2023
@bors
Copy link
Contributor

bors commented Mar 9, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

weihanglo pushed a commit to weihanglo/cargo that referenced this pull request Mar 9, 2023
@bors @weihanglo
Auto merge of rust-lang#11820 - weihanglo:bump-crates-io, r=ehuss
881b030 
Bump crates-io to 0.36.0

This was an overlook of rust-lang#11600

Since we already got rust-lang#11806 to backport, I guess it is not harmful to <https://github.com/rust-lang/cargo/labels/beta-nominated> this as well.  Maybe it do need a backport as `src/cargo/ops/registry.rs` use a new public API from that PR.

BTW, please help check if it is really a breaking change.
@weihanglo weihanglo mentioned this pull request Mar 9, 2023
Merged
bors added a commit that referenced this pull request Mar 10, 2023
@bors
Auto merge of #11823 - weihanglo:rust-1.69.0, r=ehuss
4a4d795 
[beta-1.69] backport #11820

Beta backports:

- #11820

In order to make CI pass, the following PRs are also cherry-picked:

- #11817
@weihanglo weihanglo deleted the bump-crates-io branch March 10, 2023 13:04
weihanglo added a commit to weihanglo/rust that referenced this pull request Mar 14, 2023
@weihanglo
Update cargo
3c7df56 
14 commits in 7d3033d2e59383fd76193daf9423c3d141972a7d..4a3c588b1f0a8e2dc8dd8789dbf3b6a71b02ed49
2023-03-08 17:05:08 +0000 to 2023-03-14 14:05:36 +0000
- ci: make clean-test-output a script for reuse (rust-lang/cargo#11848)
- Accurately show status when downgrading dependencies (rust-lang/cargo#11839)
- docs(contrib): Move Design Principles earlier in the book (rust-lang/cargo#11842)
- docs(contrib): Point compilation docs to doc comments (rust-lang/cargo#11841)
- `cargo install --git` multiple packages with binaries found hint (rust-lang/cargo#11835)
- Disable flaky auth tests when `gitoxide` runs them (rust-lang/cargo#11830)
- Add some documentation on writing cross-compilation tests (rust-lang/cargo#11825)
- chore: Use sparse protocol on stable CI (rust-lang/cargo#11829)
- Notice for potential unexpected shell expansions in help text of `cargo-add` (rust-lang/cargo#11826)
- Add tracking issue to gitoxide unstable docs (rust-lang/cargo#11822)
- Bump crates-io to 0.36.0 (rust-lang/cargo#11820)
- Bump to 0.71.0; update changelog (rust-lang/cargo#11815)
- docs(contrib): Move overview to lib (rust-lang/cargo#11809)
- Fix semver check for 1.68 (rust-lang/cargo#11817)
@weihanglo weihanglo mentioned this pull request Mar 14, 2023
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 15, 2023
@Dylan-DPC
Rollup merge of rust-lang#109150 - weihanglo:update-cargo, r=weihanglo
a08516b 
Update cargo

14 commits in 7d3033d2e59383fd76193daf9423c3d141972a7d..4a3c588b1f0a8e2dc8dd8789dbf3b6a71b02ed49
2023-03-08 17:05:08 +0000 to 2023-03-14 14:05:36 +0000
- ci: make clean-test-output a script for reuse (rust-lang/cargo#11848)
- Accurately show status when downgrading dependencies (rust-lang/cargo#11839)
- docs(contrib): Move Design Principles earlier in the book (rust-lang/cargo#11842)
- docs(contrib): Point compilation docs to doc comments (rust-lang/cargo#11841)
- `cargo install --git` multiple packages with binaries found hint (rust-lang/cargo#11835)
- Disable flaky auth tests when `gitoxide` runs them (rust-lang/cargo#11830)
- Add some documentation on writing cross-compilation tests (rust-lang/cargo#11825)
- chore: Use sparse protocol on stable CI (rust-lang/cargo#11829)
- Notice for potential unexpected shell expansions in help text of `cargo-add` (rust-lang/cargo#11826)
- Add tracking issue to gitoxide unstable docs (rust-lang/cargo#11822)
- Bump crates-io to 0.36.0 (rust-lang/cargo#11820)
- Bump to 0.71.0; update changelog (rust-lang/cargo#11815)
- docs(contrib): Move overview to lib (rust-lang/cargo#11809)
- Fix semver check for 1.68 (rust-lang/cargo#11817)

r? `@ghost`
@weihanglo weihanglo mentioned this pull request Mar 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2023
@bors
Auto merge of rust-lang#109265 - weihanglo:update-beta-cargo, r=weiha…
bdd077d 
…nglo

[beta-1.69] cargo beta backports

3 commits in 9880b408a3af50c08fab3dbf4aa2a972df71e951..7b18c85808a6b45ec8364bf730617b6f13e0f9f8
2023-02-28 19:39:39 +0000 to 2023-03-17 12:29:33 +0000
- [beta-1.69] backport rust-lang/cargo#11824 (rust-lang/cargo#11863)
- [beta-1.69] backport rust-lang/cargo#11820 (rust-lang/cargo#11823)
- chore: Backport rust-lang/cargo#11630 to `1.69.0` (rust-lang/cargo#11806)

r? `@ghost`
@ehuss ehuss added this to the 1.70.0 milestone Mar 26, 2023
@weihanglo weihanglo mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
A-interacts-with-crates.io Area: interaction with registries beta-nominated Nominated to backport to the beta branch. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
5 participants
@weihanglo @rustbot @epage @bors @ehuss