Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin and bump libgit2-sys #11913

Closed
wants to merge 1 commit into from
Closed

Unpin and bump libgit2-sys #11913

wants to merge 1 commit into from

Conversation

pinkforest
Copy link
Contributor

@pinkforest pinkforest commented Mar 30, 2023 •
edited
Loading

This was temporarily pinned =0.14.1 in: #11609

However 0.14.2 addresses RUSTSEC-2023-0003 / CVE-2023-22742 whilst this prevents any downstream bumping as well:

Since the underlying Windows issues have been resolved:

This would be okay to unpin and bump I would assume ?

@rustbot
Copy link
Collaborator

rustbot commented Mar 30, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2023
@ehuss
Copy link
Contributor

ehuss commented Mar 30, 2023

Unfortunately this can't be unpinned, yet. It is waiting on rust-lang/git2-rs#935 and a new release.

@bors
Copy link
Contributor

bors commented Apr 3, 2023

☔ The latest upstream changes (presumably #11928) made this pull request unmergeable. Please resolve the merge conflicts.

@pinkforest
Copy link
Contributor Author

Cool looks like this was solved in #11928 - thanks! 🥳

What cargo release this would be going to be in ?

@pinkforest pinkforest closed this Apr 3, 2023
@pinkforest pinkforest deleted the chore-unpin-libgit2-sys branch April 3, 2023 21:08
@ehuss
Copy link
Contributor

ehuss commented Apr 3, 2023

1.70 if there aren't any hiccups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@weihanglo weihanglo

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pinkforest @rustbot @ehuss @bors @weihanglo