Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-1.69] Add the Win32_System_Console feature since it is used #12017

Merged
merged 3 commits into from
Apr 25, 2023
Merged

[stable-1.69] Add the Win32_System_Console feature since it is used #12017

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df504e1
Add the Win32_System_Console feature since it is used
lu-zero Apr 22, 2023
69be516
Auto merge of #12011 - ehuss:fix-semver-checks, r=epage
bors Apr 20, 2023
8cdc12c
Bump patch version of `cargo`.
ehuss Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ features = [
"Win32_Foundation",
"Win32_Storage_FileSystem",
"Win32_System_IO",
"Win32_System_Console",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a heads up, as this is a backport into the rust-1.69.0 branch, that implies that we'd be doing a patch release of rust for this. Could you expand on why that is needed? By appearance, this should only be needed for cargo-as-a-library and this problem can easily be worked around in the dependent crate by requiring the feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the issue in cargo-c this way, here how it present itself.

I prepared it in case we want a point release.

"Win32_System_Threading",
"Win32_System_JobObjects",
"Win32_Security",
Expand Down