-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use [workspace.dependencies]
#12057
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-cfg-expr
Area: Platform cfg expressions
A-cli-help
Area: built-in command-line help
A-dependency-resolution
Area: dependency resolution and the resolver
A-environment-variables
Area: environment variables
A-infrastructure
Area: infrastructure around the cargo repo, ci, releases, etc.
A-interacts-with-crates.io
Area: interaction with registries
A-registry-authentication
Area: registry authentication and authorization (authn authz)
A-semver
Area: semver specifications, version matching, etc.
A-testing-cargo-itself
Area: cargo's tests
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 28, 2023
weihanglo
reviewed
Apr 28, 2023
Muscraft
force-pushed
the
use-ws-deps
branch
2 times, most recently
from
May 2, 2023 18:30
ac07b42
to
e69343b
Compare
weihanglo
reviewed
May 2, 2023
☔ The latest upstream changes (presumably #11840) made this pull request unmergeable. Please resolve the merge conflicts. |
Muscraft
force-pushed
the
use-ws-deps
branch
2 times, most recently
from
May 3, 2023 16:33
d2a58ec
to
34b8c39
Compare
weihanglo
approved these changes
May 3, 2023
Let's go! @bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 3, 2023
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2023
Update cargo 10 commits in ac84010322a31f4a581dafe26258aa4ac8dea9cd..569b648b5831ae8a515e90c80843a5287c3304ef 2023-05-02 13:41:16 +0000 to 2023-05-05 15:49:44 +0000 - xtask-unpublished: output a markdown table (rust-lang/cargo#12085) - fix: hack around `libsysroot` instead of `libtest` (rust-lang/cargo#12088) - Optimize usage under rustup. (rust-lang/cargo#11917) - Update lock to normalize `home` dep (rust-lang/cargo#12084) - fix: doc-test failures (rust-lang/cargo#12055) - feat(cargo-metadata): add `workspace_default_members` (rust-lang/cargo#11978) - doc: clarify implications of `cargo-yank` (rust-lang/cargo#11862) - chore: Use `[workspace.dependencies]` (rust-lang/cargo#12057) - support for shallow clones and fetches with `gitoxide` (rust-lang/cargo#11840) - Build by PackageIdSpec, not name, to avoid ambiguity (rust-lang/cargo#12015) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-cfg-expr
Area: Platform cfg expressions
A-cli-help
Area: built-in command-line help
A-dependency-resolution
Area: dependency resolution and the resolver
A-environment-variables
Area: environment variables
A-infrastructure
Area: infrastructure around the cargo repo, ci, releases, etc.
A-interacts-with-crates.io
Area: interaction with registries
A-registry-authentication
Area: registry authentication and authorization (authn authz)
A-semver
Area: semver specifications, version matching, etc.
A-testing-cargo-itself
Area: cargo's tests
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Keeping shared dependencies in sync. It does this by utilizing workspace inheritance and adding
[workspace.dependencies]
.Additional information
The ability to use workspace inheritance was added in #11851, as that PR added a workspace for
cargo
.The changes were made by a tool I wrote to assist in finding duplicate dependencies.