Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: registry source cleanup #12240

Merged
merged 5 commits into from
Jun 8, 2023
Merged

refactor: registry source cleanup #12240

merged 5 commits into from
Jun 8, 2023

Commits on Jun 7, 2023

  1. refactor: move constants closer to where they are used 

    This is quite straightforward.
    @weihanglo
    weihanglo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    1c7fc5d View commit details
    Browse the repository at this point in the history

  2. refactor: use the term "index schema" instead of "index format" 

    We had index format version and index file version. Both sometimes
are written as "index version". This is so confusing that I need to
check to source code back-and-forth.

Today we make "index format version", which refers to the exact
representation of a index file, rename to "index schema version".
Other index file version of index version should just mean the opaque
version of an index file for cache invalidation use.
    @weihanglo
    weihanglo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    c4083bb View commit details
    Browse the repository at this point in the history

  3. refactor: move RegistryPackage to index module 

    `RegistryPackage` is a line in a raw registyr index file. This should
belong to `index.rs` module.
    @weihanglo
    weihanglo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    875a4c6 View commit details
    Browse the repository at this point in the history

  4. refactor: use str::to_lowercase 

    This piece of code was written before 1.2 and `str::to_lowercase`
is an API came out in Rust 1.2.
    @weihanglo
    weihanglo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    c609ee2 View commit details
    Browse the repository at this point in the history

  5. refactor: rename RegistryPackage to IndexPackage 

    This is a better name to reflect it is from "index" files.
    @weihanglo
    weihanglo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    c977baa View commit details
    Browse the repository at this point in the history