Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Put cargo-add change under nightly #12343

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

epage
Copy link
Contributor

@epage epage commented Jul 10, 2023

I'm assuming we'll want to beta-backport this.

I'm assuming we'll want to beta-backport this.
@rustbot
Copy link
Collaborator

rustbot commented Jul 10, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2023
@epage epage added beta-nominated Nominated to backport to the beta branch. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2023
@epage
Copy link
Contributor Author

epage commented Jul 10, 2023

This was carried over into the rust 1.71 release notes where I noticed it. See also rust-lang/rust#113541.

@ehuss
Copy link
Contributor

ehuss commented Jul 10, 2023

Thanks. I don't think this necessarily needs a backport since the release notes and blog posts all link directly to the master branch here. I don't think anyone sees the CHANGELOG from the release branches. Also, I believe the 1.71 stable release has already left the station.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 10, 2023

📌 Commit 642e0c3 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 10, 2023
@bors
Copy link
Contributor

bors commented Jul 10, 2023

⌛ Testing commit 642e0c3 with merge 445838d...

@epage epage removed the beta-nominated Nominated to backport to the beta branch. label Jul 10, 2023
@bors
Copy link
Contributor

bors commented Jul 10, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 445838d to master...

@bors bors merged commit 445838d into rust-lang:master Jul 10, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 12, 2023
Update cargo

10 commits in 45782b6b8afd1da042d45c2daeec9c0744f72cc7..694a579566a9a1482b20aff8a68f0e4edd99bd28
2023-07-05 16:54:51 +0000 to 2023-07-11 22:28:29 +0000
- fix(embedded): Always generate valid package names (rust-lang/cargo#12349)
- fix(embedded): Error on unsupported commands (rust-lang/cargo#12350)
- chore(ci): Automatically test new packages by using `--workspace` (rust-lang/cargo#12342)
- contrib docs: Add some more detail about how publishing works (rust-lang/cargo#12344)
- docs: Put cargo-add change under nightly (rust-lang/cargo#12343)
- Minor: Use "number" instead of "digit" when explaining Cargo's use of semver (rust-lang/cargo#12340)
- Update criterion (rust-lang/cargo#12338)
- Add profile strip to config docs. (rust-lang/cargo#12337)
- update re: multiple versions that differ only in the metadata tag (rust-lang/cargo#12335)
- doc: state `PackageId`/`SourceId` string is opaque (rust-lang/cargo#12313)

r? `@ghost`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 13, 2023
Update cargo

10 commits in 45782b6b8afd1da042d45c2daeec9c0744f72cc7..694a579566a9a1482b20aff8a68f0e4edd99bd28
2023-07-05 16:54:51 +0000 to 2023-07-11 22:28:29 +0000
- fix(embedded): Always generate valid package names (rust-lang/cargo#12349)
- fix(embedded): Error on unsupported commands (rust-lang/cargo#12350)
- chore(ci): Automatically test new packages by using `--workspace` (rust-lang/cargo#12342)
- contrib docs: Add some more detail about how publishing works (rust-lang/cargo#12344)
- docs: Put cargo-add change under nightly (rust-lang/cargo#12343)
- Minor: Use "number" instead of "digit" when explaining Cargo's use of semver (rust-lang/cargo#12340)
- Update criterion (rust-lang/cargo#12338)
- Add profile strip to config docs. (rust-lang/cargo#12337)
- update re: multiple versions that differ only in the metadata tag (rust-lang/cargo#12335)
- doc: state `PackageId`/`SourceId` string is opaque (rust-lang/cargo#12313)

r? ``@ghost``
@epage epage deleted the change branch July 18, 2023 02:53
epage added a commit to epage/rust that referenced this pull request Jul 18, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2023
docs(release): Remove nightly-only cargo item

See rust-lang/cargo#12343
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2023
docs(release): Remove nightly-only cargo item

See rust-lang/cargo#12343
@ehuss ehuss added this to the 1.73.0 milestone Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants