Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resolver): Prefer MSRV, rather than ignore incompatible #12950

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix(resolver): Prefer MSRV, rather than ignore incompatible #12950

merged 2 commits into from
Nov 14, 2023

Commits on Nov 14, 2023

  1. test(resolver): Verify backtracking for MSRV resolver

    @epage
    epage committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0bc5d22 View commit details
    Browse the repository at this point in the history

  2. fix(resolver): Prefer MSRV, rather than ignore incompatible 

    This is another experiment for rust-lang#9930.

Comparing preferring over exclusively using MSRV compatible:

Benefits
- Better error messages
- `--ignore-rust-version` is implicitly sticky

Downsides
- Can't backtrack for MSRV compatible version
- Still requires workspace-wide MSRV (compared to our desired end state of declaring MSRV as yet another dependency)

This builds on rust-lang#12930
    @epage
    epage committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0d29d3f View commit details
    Browse the repository at this point in the history