-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update rust crate handlebars to v4.5.0
#13168
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
@rustbot author Please let us know if you have any questions. |
@rustbot ready |
Could you update the commits for how you'd want them merged (every commit being "correct")? |
The example below will break markdown rendering while following the latest version of handlebars strip rules. <!-- template -->
{{#options}}
some content...
{{/options}}
### Section options
<!-- original output -->
<dl>
some content...
</dl>
### Section options
<!-- output after update handlebars -->
<dl>
some content...
</dl>
### Section options <--- adjacent html and headings breaks markdown rendering What I have changed is to add an extra newline to preserve the original behavior of the |
To be clear, it looks like your commits in the PR were checkpoints during your development and I suspect they don't all work. I was asking to clean them up, whether thats for squashing all of them into one commit or doing multiple, I leave it to you. |
b0d78f1
to
b96b244
Compare
Ok, done. |
Thanks! @bors r+ |
☀️ Test successful - checks-actions |
Update cargo 10 commits in 1a2666ddd14cf0a255d4ddb61c63531c259a7b39..363a2d11320faf531f6aacd1ea067c6bc08343b9 2023-12-17 17:53:53 +0000 to 2023-12-22 03:12:42 +0000 - refactor: centralize git checkouts and db paths (rust-lang/cargo#13187) - Bump to 0.78.0; update changelog (rust-lang/cargo#13192) - refactor: custom error types for `cargo-util-schemas` (rust-lang/cargo#13186) - chore(deps): update rust crate handlebars to `v4.5.0` (rust-lang/cargo#13168) - Hold the mutate exclusive lock when vendoring (rust-lang/cargo#12509) - refactor: clean up package metadata (rust-lang/cargo#13184) - ci: check SemVer for cargo-util-schemas on CI (rust-lang/cargo#13185) - refactor(schemas): Pull out as `cargo-util-schemas` (rust-lang/cargo#13178) - chore(rustfix): rename Readme.md to README.md (rust-lang/cargo#13181) - chore(rustfix): remove useless clippy rules and fix a typo (rust-lang/cargo#13182) r? ghost
In the latest version of
handlebars
, rules for whitespace auto elimination is to check if the directive{{# xxx}}`` and ``{{/ xxx}}
is holding a whole line, with leading and trailing whitespaces counted, and then remove the trailing NEWLINE (Seetemplate.rs
).This PR changes includes (fixes #13162):
handlebars
crate tov4.5.0
.options
,option
to align with the new strip rules, preserving the original behavior.