refactor: give some better examples for package ID spec #13202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 27, 2023
Update cargo 7 commits in 363a2d11320faf531f6aacd1ea067c6bc08343b9..ac6bbb33293d8d424c17ecdb42af3aac25fb7295 2023-12-22 03:12:42 +0000 to 2023-12-26 23:22:08 +0000 - docs: fix link to nightly doc of cargo-util-schemas (rust-lang/cargo#13209) - doc: improve word usage (rust-lang/cargo#13206) - fix: clarify `--path` is the installation source not destination (rust-lang/cargo#13205) - refactor: give some better examples for package ID spec (rust-lang/cargo#13202) - chore: fix a typo (rust-lang/cargo#13201) - Extend the build directive syntax with `cargo::` (rust-lang/cargo#12201) - Rework `--check-cfg` generation comment (rust-lang/cargo#13195) r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 27, 2023
Update cargo 7 commits in 363a2d11320faf531f6aacd1ea067c6bc08343b9..ac6bbb33293d8d424c17ecdb42af3aac25fb7295 2023-12-22 03:12:42 +0000 to 2023-12-26 23:22:08 +0000 - docs: fix link to nightly doc of cargo-util-schemas (rust-lang/cargo#13209) - doc: improve word usage (rust-lang/cargo#13206) - fix: clarify `--path` is the installation source not destination (rust-lang/cargo#13205) - refactor: give some better examples for package ID spec (rust-lang/cargo#13202) - chore: fix a typo (rust-lang/cargo#13201) - Extend the build directive syntax with `cargo::` (rust-lang/cargo#12201) - Rework `--check-cfg` generation comment (rust-lang/cargo#13195) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
The old examples are so confusing because Cargo does not use those formats. For instance: We use
https://github.com/rust-lang/crates.io-index#fooinstead ofhttps://github.com/rust-lang/crates.io-index/foo. You can verify it by using thecargo pkgidcommand.How should we test and review this PR?
It should covered by rustdoc tests.
Additional information
r? @epage
We discussed it one time during Cargo office hours.