Silently ignore cargo::rustc-check-cfg to avoid MSRV annoyance when stabilizing -Zcheck-cfg
#13438
Conversation
|
r? @weihanglo rustbot has assigned @weihanglo. Use r? to explicitly pick a reviewer |
rustbot
added
A-build-scripts
| check_cfgs.push(value.to_string()); | ||
| } else { | ||
| warnings.push(format!( | ||
| "{}{} requires -Zcheck-cfg flag", | ||
| syntax_prefix, key | ||
| )); | ||
| // silently ignoring the instruction to try to | ||
| // minimise MSRV annoyance when stabilizing -Zcheck-cfg | ||
| } | ||
| } |
There was a problem hiding this comment.
imo we should make each of these conditioned this on nightly vs stable
There was a problem hiding this comment.
wouldn't this create the same issue we trying to avoid?
or do you mean that the silencing part should be conditioned on nightly/stable ?
There was a problem hiding this comment.
Do you mean that it should not be silenced on nightly, so that nightly users get the warning (which is useful!)?
There was a problem hiding this comment.
The main problem we are trying to avoid is when this is stabilized but not yet in people's MSRV: they will either have to live with the build script warning on their MSRV or deal with the check-cfg warning on the latest Rust toolchain.
(btw I keep going back and forth between "meh, this is fine" and "we probably should still warn")
|
☔ The latest upstream changes (presumably #13409) made this pull request unmergeable. Please resolve the merge conflicts. |
Urgau
force-pushed
the
check-cfg-msrv-annoyance
branch
from
91c0724
to
da59007
Compare
|
@bors r+ |
|
(Oh, I think homu is down. Will probably need to kick this once it is fixed.) |
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Silently ignore `cargo::rustc-check-cfg` to avoid MSRV annoyance when stabilizing `-Zcheck-cfg` This PR, removes the warning when trying to use `cargo::rustc-check-cfg` on stable or nightly (without the nightly-only `-Zcheck-cfg` flag) to avoid MSRV annoyance when stabilizing `-Zcheck-cfg`. See this [Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/check-cfg.20backwards.20compatible.20warnings) for more information and context. cc `@ehuss`
[beta-1.77] Backport ignore `cargo::rustc-check-cfg` This is a beta backport of #13438 (comment) to disable the warning when `cargo::rustc-check-cfg` is used in a build script on stable in order to provide a broader window where we can stabilize check-cfg, and allow developers to avoid the warning when they use a range of different Rust versions (such as stable and nightly). Also backports to fix CI: * #13455 — Remove unnecessary use statement in metabuild
Update cargo 12 commits in 8964c8ccff6e420e2a38b8696d178d69fab84d9d..f772ec0224d3755ce52ac5128a80319fb2eb45d0 2024-02-27 19:22:46 +0000 to 2024-03-01 22:57:35 +0000 - feat(toml): Warn on unset Edition (rust-lang/cargo#13505) - fix(msrv): Report all incompatible packages, not just a random one (rust-lang/cargo#13514) - refactor: abstract `std::fs` away from on-disk index cache (rust-lang/cargo#13515) - chore(deps): update compatible (rust-lang/cargo#13507) - chore(deps): update rust crate rusqlite to 0.31.0 (rust-lang/cargo#13510) - [docs]: Clarify vendored sources as read-only and way to modify (rust-lang/cargo#13512) - chore(deps): update rust crate supports-hyperlinks to v3 (rust-lang/cargo#13511) - refactor: Clarify more Config -> Context (rust-lang/cargo#13506) - test: Make `edition` explicit in packages (rust-lang/cargo#13504) - Add all unit's children recursively for `doc.extern-map` option (rust-lang/cargo#13481) - fix(rustc): Always pass --edition to rustc (rust-lang/cargo#13499) - Silently ignore `cargo::rustc-check-cfg` to avoid MSRV annoyance when stabilizing `-Zcheck-cfg` (rust-lang/cargo#13438) r? ghost
This PR, removes the warning when trying to use
cargo::rustc-check-cfgon stable or nightly (without the nightly-only-Zcheck-cfgflag) to avoid MSRV annoyance when stabilizing-Zcheck-cfg.See this Zulip thread for more information and context.
cc @ehuss