Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unknown-lints lint #13639

Closed
wants to merge 3 commits into from
Closed

Conversation

Muscraft
Copy link
Member

@Muscraft Muscraft commented Mar 25, 2024

This PR adds a lint for unknown-lints similar rustc::unknown-lints. This will help users know when they are passing something to cargo that cargo doesn't understand.

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-workspaces Area: workspaces S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2024
{
if let Some(cargo_lints) = lints.get("cargo") {
for (name, _) in cargo_lints.iter() {
let normalized_name = name.replace("-", "_");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is having me lean more towards normalizing earlier in the process

Comment on lines +198 to +201
if let Some(lints) = original_toml
.workspace
.as_ref()
.map_or(&None, |ws| &ws.lints)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this should be treated as a separate "workspace" lint that is only subject to workspace.lints so we have consistency between virtual and real workspace packages.

@@ -763,7 +763,6 @@ fn cargo_lints_nightly_required() {
authors = []

[lints.cargo]
"unused-features" = "deny"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these here and why are they being removed?

@bors
Copy link
Collaborator

bors commented Apr 11, 2024

☔ The latest upstream changes (presumably #13740) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss
Copy link
Contributor

ehuss commented Apr 22, 2024

r? epage
if you don't mind.

@rustbot rustbot assigned epage and unassigned ehuss Apr 22, 2024
@Muscraft
Copy link
Member Author

Muscraft commented May 1, 2024

Going to close in favor of #13837, as it contains the addition of an unknown_lints
lint

@Muscraft Muscraft closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-workspaces Area: workspaces S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants