Don't depend on ? affecting type inference in weird ways
#13706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Merging this more as a code cleanup. For this breaking in the future, I'm assuming that is non-urgent as I'm assuming a lot needs to be worked out to uphold stability expectations before that will matter. @bors r+ |
bors
added
S-waiting-on-bors
weihanglo
reviewed
Apr 5, 2024
|
☀️ Test successful - checks-actions |
|
@epage yes, this is non urgent (although this needs to happen before the change, so that rustc's CI can pass), so I just made a PR since this is a simple change & is indeed a little cleanup. @weihanglo this is required for the crater run on rust-lang/rust#122412, although I think I can workaround that. |
|
Thanks. I could do a cargo submodule update earlier if needed. Usually it happens on Tuesday and Friday. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2024
Update cargo 9 commits in 0637083df5bbdcc951845f0d2eff6999cdb6d30a..28e7b2bc0a812f90126be30f48a00a4ada990eaa 2024-04-02 23:55:05 +0000 to 2024-04-05 19:31:01 +0000 - refactor(toml): Decouple target discovery from Target creation (rust-lang/cargo#13701) - Don't depend on `?` affecting type inference in weird ways (rust-lang/cargo#13706) - test(metadata): Show behavior with TOML-specific types (rust-lang/cargo#13703) - fix: adjust tracing verbosity in list_files_git (rust-lang/cargo#13704) - doc: comments on `PackageRegistry` (rust-lang/cargo#13698) - Switch to using gitoxide by default for listing files (rust-lang/cargo#13696) - Allow precise update to prerelease. (rust-lang/cargo#13626) - refactor(toml): Split out an explicit step to resolve `Cargo.toml` (rust-lang/cargo#13693) - chore(deps): update rust crate base64 to 0.22.0 (rust-lang/cargo#13675) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely to stop working in the future versions of Rust, see rust-lang/rust#122412 (comment).