Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade to openssl v1.1.1 (again) #13731

Merged
merged 3 commits into from
Apr 10, 2024
Merged

chore: downgrade to openssl v1.1.1 (again) #13731

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1717a35
chore: downgrade to openssl v1.1.1 (again)
weihanglo Apr 10, 2024
399f2c7
chore: tell renovatebot to not touch openssl (temporarily)
weihanglo Apr 10, 2024
686057b
chore: pin openssl-sys to `=0.9.92`
weihanglo Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@
matchUpdateTypes: [
'patch',
],
// See rust-lang/cargo#13546 and openssl/openssl#23376 for the exclusion
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End up using excludePackageNames, though I completely don't know if it can detect lockfile-only updates.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epage any chance you know this is gonna work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RenovateBot will no try to upgrade us but if something else causes an upgrade, then it will still happen.

Granted, if they are running cargo update <dep> then nothing should update it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why they got upgraded by renovatebot. There was nothing preventing me from cargo update openssl --precise <oldversion>. Weird.

excludePackageNames: ['openssl', 'openssl-src', 'openssl-sys'],
automerge: false,
groupName: 'compatible',
},
Expand All @@ -89,6 +91,8 @@
matchUpdateTypes: [
'minor',
],
// See rust-lang/cargo#13546 and openssl/openssl#23376 for the exclusion
excludePackageNames: ['openssl', 'openssl-src', 'openssl-sys'],
automerge: false,
groupName: 'compatible',
},
Expand Down