Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toml): Don't lose 'public' when inheriting a dep #13836

Merged
merged 4 commits into from
May 1, 2024
Merged

fix(toml): Don't lose 'public' when inheriting a dep #13836

merged 4 commits into from
May 1, 2024

Commits on May 1, 2024

  1. refactor(toml): Clarify which dep we are talking about

    @epage
    epage committed May 1, 2024
    Configuration menu
    Copy the full SHA
    7820a0b View commit details
    Browse the repository at this point in the history

  2. refactor(toml): Always create a detailed dep 

    This minimizes risk as we add more dependency features
    @epage
    epage committed May 1, 2024
    Configuration menu
    Copy the full SHA
    bfe62a6 View commit details
    Browse the repository at this point in the history

  3. fix(toml): Don't lose 'public' when inheriting a dep 

    When inheriting a simple dep, we preserved the package dep's `public`
field but lost it when inheriting a detailed dep.

This was done by consolidating the code paths.  This also reduces the
risk of us doing this again in the future.
    @epage
    epage committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e8ba122 View commit details
    Browse the repository at this point in the history

  4. refactor(toml): Use exhaustive destructure to ensure we inherit dep f… 

    …ields
    @epage
    epage committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1fc3668 View commit details
    Browse the repository at this point in the history