test: migrate features_are_quoted to snapbox #14051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
weihanglo
reviewed
Jun 12, 2024
tests/testsuite/shell_quoting.rs
Outdated
Comment on lines
34
to
40
| error[E0425]: cannot find value `error` in this scope | ||
| --> src/main.rs:1:12 | ||
| | | ||
| 1 | fn main() {error} | ||
| | ^^^^^ not found in this scope | ||
|
|
||
| For more information about this error, try `rustc --explain E0425`. |
There was a problem hiding this comment.
Snapshotting rustc output is a bit risky. If applicable we should omit it by ....
Suggested change
| error[E0425]: cannot find value `error` in this scope | |
| --> src/main.rs:1:12 | |
| | | |
| 1 | fn main() {error} | |
| | ^^^^^ not found in this scope | |
| For more information about this error, try `rustc --explain E0425`. | |
| ... |
There was a problem hiding this comment.
By risky I mean rustc output is not guaranteed stable and might break cargo test suites between different toolchain versions.
There was a problem hiding this comment.
I've added this to the porting steps
- If replacing a
containswith an equality check, use multi-line globs (...) for rustc errors that weren't previously matched to minimize tying Cargo's tests to the exact output of rustc
Co-authored-by: Weihang Lo <weihanglo@users.noreply.github.com>
henry40408
force-pushed
the
issue-14039-shell-quoting
branch
from
4851d22
to
3a19de7
Compare
weihanglo
approved these changes
Jun 13, 2024
|
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 15, 2024
Update cargo 13 commits in 4dcbca118ab7f9ffac4728004c983754bc6a04ff..a1f47ec3f7cd076986f1bfcd7061f2e8cb1a726e 2024-06-11 16:27:02 +0000 to 2024-06-15 01:10:07 +0000 - Change verification order during packaging. (rust-lang/cargo#14074) - Update git2 for libgit2 1.8.1 (rust-lang/cargo#14067) - Fix some documentation misspellings (rust-lang/cargo#14066) - chore(deps): update msrv (1 version) to v1.79 (rust-lang/cargo#14063) - test: Redact conditional compile-fail warning (rust-lang/cargo#14064) - Migrate a few test files to snapbox (rust-lang/cargo#14048) - docs(contrib): Improve triage instructions (rust-lang/cargo#14052) - chore(ci): Upgrade cargo-semver-checks (rust-lang/cargo#14062) - Revert rust-lang/cargo#13630 as rustc ignores `-C strip` on MSVC (rust-lang/cargo#14061) - test: migrate features_are_quoted to snapbox (rust-lang/cargo#14051) - Add assert redactions (rust-lang/cargo#14054) - test: migrate build_script_env to snapbox (rust-lang/cargo#14044) - docs: Iterate on --breaking docs (rust-lang/cargo#14047) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Part of #14039.
Migrate
tests/testsuite/shell_quoting.rsto snapbox.How should we test and review this PR?
N/A
Additional information
N/A