Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: relax redactions for rust-lang/rust #14203

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

weihanglo
Copy link
Member

To unblock submodule update in rust-lang/rust

See rust-lang/rust#127385 (comment) and each commit message.

sysroot is different when bootstrapping rustc

```
---- expected: tests/testsuite/cfg.rs:444:27
++++ actual:   stderr
   1    1 | [ERROR] output of --print=split-debuginfo missing when learning about target-specific information from rustc
   2    2 | command was: `[ROOT]/compiler/target/debug/compiler[..]--crate-type [..]`
   3    3 |
   4    4 | --- stdout
   5    5 | ___[EXE]
   6    6 | lib___.rlib
   7    7 | [..]___.[..]
   8    8 | [..]___.[..]
   9    9 | [..]___.[..]
  10   10 | [..]___.[..]
  11      - [..]rust[..]
       11 + /checkout/obj/build/[HOST_TARGET]/stage2
  12   12 |
```

https://github.com/rust-lang-ci/rust/actions/runs/9814397548/job/27101968836#step:25:10913
@rustbot
Copy link
Collaborator

rustbot commented Jul 6, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 6, 2024
@ehuss
Copy link
Contributor

ehuss commented Jul 6, 2024

Looks like you have a CI failure (unused import).

@ehuss
Copy link
Contributor

ehuss commented Jul 6, 2024

You can r=ehuss once you fix that.

`ssh` binary is not available on some platforms.

https://github.com/rust-lang-ci/rust/actions/runs/9814397548/job/27101968836#step:25:10940

```
---- git_auth::net_err_suggests_fetch_with_cli stdout ----
running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/cargo check -v`
running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/cargo check -v`
thread 'git_auth::net_err_suggests_fetch_with_cli' panicked at tests/testsuite/git_auth.rs:439:10:

---- expected: tests/testsuite/git_auth.rs:415:27
++++ actual:   stderr
   1    1 | [UPDATING] git repository `ssh://needs-proxy.invalid/git`
   2    2 | [RUNNING] `git fetch --verbose --force --update-head-ok [..]ssh://needs-proxy.invalid/git[..] [..]+HEAD:refs/remotes/origin/HEAD[..]`
   3      - ssh: Could not resolve hostname needs-proxy.invalid: [..] not known
   4      - fatal: Could not read from remote repository.
   5      -
   6      - Please make sure you have the correct access rights
   7      - and the repository exists.
        3 + [ERROR] cannot run ssh: No such file or directory
        4 + fatal: unable to fork
   8    5 | [ERROR] failed to get `foo` as a dependency of package `foo v0.0.0 ([ROOT]/foo)`
   9    6 |
  10    7 | Caused by:
  11    8 |   failed to load source for dependency `foo`
  12    9 |
          ⋮
  15   12 |
  16   13 | Caused by:
  17   14 |   failed to fetch into: [ROOT]/home/.cargo/git/db/git-[HASH]
  18   15 |
  19   16 | Caused by:
  20      -   process didn't exit successfully: `git fetch --verbose --force --update-head-ok [..]ssh://needs-proxy.invalid/git[..] [..]+HEAD:refs/remotes/origin/HEAD[..]` ([EXIT_STATUS]: 128)
       17 +   process didn't exit successfully: `git fetch --verbose --force --update-head-ok 'ssh://needs-proxy.invalid/git' '+HEAD:refs/remotes/origin/HEAD'` ([EXIT_STATUS]: 128)
```
@weihanglo
Copy link
Member Author

@bors r=ehuss

@bors
Copy link
Contributor

bors commented Jul 7, 2024

📌 Commit e491c06 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2024
@bors
Copy link
Contributor

bors commented Jul 7, 2024

⌛ Testing commit e491c06 with merge 154fdac...

@bors
Copy link
Contributor

bors commented Jul 7, 2024

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 154fdac to master...

@bors bors merged commit 154fdac into rust-lang:master Jul 7, 2024
22 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 7, 2024
Update cargo

20 commits in a515d463427b3912ec0365d106791f88c1c14e1b..154fdac39ae9629954e19e9986fd2cf2cdd8d964
2024-07-02 20:53:36 +0000 to 2024-07-07 01:28:23 +0000
- test: relax redactions for rust-lang/rust (rust-lang/cargo#14203)
- use "bootstrap" instead of "rustbuild" (rust-lang/cargo#14207)
- test: migrate serveral files to snapbox (rust-lang/cargo#14180)
- Add rustdocflags to Unit's Debug impl (rust-lang/cargo#14201)
- Allow enabling `config-include` feature in config (rust-lang/cargo#14196)
- fix(test): Restore `does_not_contain` for check (rust-lang/cargo#14198)
- test: migrate patch, pkgid, proc_macro and progress to snapbox (rust-lang/cargo#14181)
- test: Migrate jobserver to snapbox (rust-lang/cargo#14191)
- chore(deps): update msrv (3 versions) to v1.77 (rust-lang/cargo#14186)
- test: migrate build_plan and build_script to snapbox (rust-lang/cargo#14193)
- test: migrate cfg and check to snapbox (rust-lang/cargo#14185)
- test: migrate install* and inheritable_workspace_fields to snapbox (rust-lang/cargo#14170)
- Pass rustflags to artifacts built with implicit targets when using target-applies-to-host (rust-lang/cargo#13900)
- test: Migrate network tests to snapbox (rust-lang/cargo#14187)
- test: migrate some files to snapbox (rust-lang/cargo#14113)
- test: Auto-redact `... after last build at ...`; Migrate `freshness` to Snapbox (rust-lang/cargo#14161)
- chore: fix some typos (rust-lang/cargo#14182)
- fix: improve message for inactive weak optional feature with edition2024 through unused dep collection (rust-lang/cargo#14026)
- test:migrate `doc/directory/docscrape` to snapbox (rust-lang/cargo#14171)
- test: Migrate git_auth to snapbox (rust-lang/cargo#14172)
@rustbot rustbot added this to the 1.81.0 milestone Jul 7, 2024
@weihanglo weihanglo deleted the fix-redaction branch July 9, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants