fix(resolve): With `latest` message, differentiate actionable updates #14461

epage · 2024-08-27T21:29:18Z

What does this PR try to resolve?

Instead of always listing the absolutely latest version as a warning
color, we now differentiate

compatible updates are always actionable
incompatible, direct deps are always actionable

These get reported and made yellow while non-actionable messages are
unstyled.

How should we test and review this PR?

I just used a broad stroke to say "compatible" in the message means "semver
compatible" and use ^

We could focus on "compatible with dependent version reqs" which is
what will be most actionable but seeing if we can get away without
having to track all in-coming version reqs.
We could be more nuanced in language but the more verbose we are, the
more we take away from higher priority messages

Additional information

This is not intended as the solution for #13908 though it experiments with what to do for that.
This is prep work for improved MSRV reporting where we will
differentiate this further by only considering MSRV-compatible updates as actionable
(or rustc-compatible when not using MSRV-aware reslver).

Instead of always listing the absolute latest version as a warning color, we now differentiate - compatible updates are always actionable - incompatible, direct deps are always actionable These get reported and made yellow while non-actionable messages are unstyled. This is not intended as *the* solution for rust-lang#13908 though it makes improvements in that direction. This is prep work for improved MSRV reporting where we will differentiate this further by only considering MSRV-compatible updates as actionable (or rustc-compatible when not using MSRV-aware reslver). I just used a broad stroke to say "compatible" in the message means "semver compatible" and use `^` - We could focus on "compatible with dependent version reqs" which is what will be most actionable but seeing if we can get away without having to track all in-coming version reqs. - We could be more nuanced in language but the more verbose we are, the more we take away from higher priority messages

rustbot · 2024-08-27T21:29:22Z

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Muscraft

Thanks!

Muscraft · 2024-08-29T20:56:09Z

@bors r+

bors · 2024-08-29T20:56:12Z

📌 Commit 353cd87 has been approved by Muscraft

It is now in the queue for this repository.

bors · 2024-08-29T21:03:55Z

⌛ Testing commit 353cd87 with merge c1fa840...

bors · 2024-08-29T21:32:47Z

☀️ Test successful - checks-actions
Approved by: Muscraft
Pushing c1fa840 to master...

This expands on rust-lang#14461 to where only MSRV-compatible versions are "actionable". MSRV-incompatible versions are therefore unstyled. We report the MSRV needed so people can choose to unblock by updating their MSRV. I had wondered if we should report the the absolute latest MSRV-incompatible version or the one with the next higher MSRV from where the user is at. Both are reasonable use cases, so I erred with absolute latest version.

Update cargo 9 commits in 8f40fc59fb0c8df91c97405785197f3c630304ea..c1fa840a85eca53818895901a53fae34247448b2 2024-08-21 22:37:06 +0000 to 2024-08-29 21:03:53 +0000 - fix(resolve): With `latest` message, differentiate actionable updates (rust-lang/cargo#14461) - fix(pkgid): Allow open namespaces in PackageIdSpec's (rust-lang/cargo#14467) - feat(resolve): Report incompatible-with-rustc when MSRV-resolver is disabled (rust-lang/cargo#14459) - fix(resolve): Report incompatible packages with precise Rust version (rust-lang/cargo#14457) - fix(resolve): Dont show locking workspace members (rust-lang/cargo#14445) - Log details of failure if no errors were seen (rust-lang/cargo#14453) - More helpful missing feature error message (rust-lang/cargo#14436) - feat: Add matches_prerelease semantic (rust-lang/cargo#14305) - refactor(update): Prepare for smarter update messages (rust-lang/cargo#14440) r? ghost

feat(resolve): Report MSRV compatible version instead of incomptible ### What does this PR try to resolve? This expands on #14461 to where only MSRV-compatible versions are "actionable". MSRV-incompatible versions are therefore unstyled. We report the MSRV needed so people can choose to unblock by updating their MSRV. I had wondered if we should report the the absolute latest MSRV-incompatible version or the one with the next higher MSRV from where the user is at. Both are reasonable use cases, so I erred with absolute latest version. ```console $ cargo update --workspace -v ``` ![image](https://github.com/user-attachments/assets/27e40dda-287b-4223-a377-0233205307a2) ### How should we test and review this PR? I changed the label from `latest` to `available` to not have to keep coming up with relevant terms for each case. ### Additional information This is the final step before asking for new feedback on #13908

Update cargo 9 commits in 8f40fc59fb0c8df91c97405785197f3c630304ea..c1fa840a85eca53818895901a53fae34247448b2 2024-08-21 22:37:06 +0000 to 2024-08-29 21:03:53 +0000 - fix(resolve): With `latest` message, differentiate actionable updates (rust-lang/cargo#14461) - fix(pkgid): Allow open namespaces in PackageIdSpec's (rust-lang/cargo#14467) - feat(resolve): Report incompatible-with-rustc when MSRV-resolver is disabled (rust-lang/cargo#14459) - fix(resolve): Report incompatible packages with precise Rust version (rust-lang/cargo#14457) - fix(resolve): Dont show locking workspace members (rust-lang/cargo#14445) - Log details of failure if no errors were seen (rust-lang/cargo#14453) - More helpful missing feature error message (rust-lang/cargo#14436) - feat: Add matches_prerelease semantic (rust-lang/cargo#14305) - refactor(update): Prepare for smarter update messages (rust-lang/cargo#14440) r? ghost

This expands on rust-lang#14461 to where only MSRV-compatible versions are "actionable". MSRV-incompatible versions are therefore unstyled. We report the MSRV needed so people can choose to unblock by updating their MSRV. I had wondered if we should report the the absolute latest MSRV-incompatible version or the one with the next higher MSRV from where the user is at. Both are reasonable use cases, so I erred with absolute latest version.

Update cargo 9 commits in 8f40fc59fb0c8df91c97405785197f3c630304ea..c1fa840a85eca53818895901a53fae34247448b2 2024-08-21 22:37:06 +0000 to 2024-08-29 21:03:53 +0000 - fix(resolve): With `latest` message, differentiate actionable updates (rust-lang/cargo#14461) - fix(pkgid): Allow open namespaces in PackageIdSpec's (rust-lang/cargo#14467) - feat(resolve): Report incompatible-with-rustc when MSRV-resolver is disabled (rust-lang/cargo#14459) - fix(resolve): Report incompatible packages with precise Rust version (rust-lang/cargo#14457) - fix(resolve): Dont show locking workspace members (rust-lang/cargo#14445) - Log details of failure if no errors were seen (rust-lang/cargo#14453) - More helpful missing feature error message (rust-lang/cargo#14436) - feat: Add matches_prerelease semantic (rust-lang/cargo#14305) - refactor(update): Prepare for smarter update messages (rust-lang/cargo#14440) r? ghost

epage added 4 commits August 27, 2024 13:00

refactor(resolve): Give report_latest more formatting control

c60d317

refactor(resolve): Give room for more policies

78d6795

refactor(resolve): Give more details to 'report_latest'

545ca21

rustbot assigned ehuss Aug 27, 2024

rustbot added A-semver Area: semver specifications, version matching, etc. Command-update S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2024

epage mentioned this pull request Aug 27, 2024

cargo update should not highlight non-semver-compatible "(latest: v0.23.5)" for indirect dependencies #13908

Closed

Muscraft approved these changes Aug 29, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2024

bors merged commit c1fa840 into rust-lang:master Aug 29, 2024
22 checks passed

epage deleted the actionable branch August 29, 2024 21:36

epage mentioned this pull request Aug 30, 2024

feat(resolve): Report MSRV compatible version instead of incomptible #14471

Merged

weihanglo mentioned this pull request Aug 31, 2024

Update cargo rust-lang/rust#129798

Merged

rustbot added this to the 1.83.0 milestone Sep 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(resolve): With `latest` message, differentiate actionable updates #14461

fix(resolve): With `latest` message, differentiate actionable updates #14461

epage commented Aug 27, 2024

rustbot commented Aug 27, 2024

Muscraft left a comment

Muscraft commented Aug 29, 2024

bors commented Aug 29, 2024

bors commented Aug 29, 2024

bors commented Aug 29, 2024

fix(resolve): With latest message, differentiate actionable updates #14461

fix(resolve): With latest message, differentiate actionable updates #14461

Conversation

epage commented Aug 27, 2024

What does this PR try to resolve?

How should we test and review this PR?

Additional information

rustbot commented Aug 27, 2024

Muscraft left a comment

Choose a reason for hiding this comment

Muscraft commented Aug 29, 2024

bors commented Aug 29, 2024

bors commented Aug 29, 2024

bors commented Aug 29, 2024

fix(resolve): With `latest` message, differentiate actionable updates #14461

fix(resolve): With `latest` message, differentiate actionable updates #14461