Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of comma separated values in --crate-type flag #14499

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix parsing of comma separated values in --crate-type flag #14499

merged 1 commit into from
Sep 9, 2024

Commits on Sep 5, 2024

  1. Fix parsing of comma separated values in --crate-type flag 

    According to the documentation the --crate-type flag accepts a comma
separated list of crate types. However, these are never actually
split into individual items and passed verbatim to rustc.

Since cargo fails to associate cases such as 'staticlib,cdylib' to
a specific crate type internally, it has to invoke rustc to determine
the output file types for this unknown crate type, which returns only
the first file type of the first crate type in the list. Consequently
cargo will be looking only for a single '.a' artifact on Linux to be
copied to the target directory.

Fix this by splitting the list of provided crate types into individual
items before further processing them.
    @felixmoebius
    felixmoebius committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    fb672fa View commit details
    Browse the repository at this point in the history