Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce CARGO_PKG_EDITION env var #14873

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce CARGO_PKG_EDITION env var #14873

wants to merge 1 commit into from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Nov 29, 2024 •
edited
Loading

Add CARGO_PKG_EDITION environment variable, allowing build scripts to determine the language edition of the crate being compiled.

Fixes #14872

TBD - EnvVar Name

  • CARGO_PKG_EDITION
  • CARGO_PKG_RUST_EDITION
  • CARGO_PKG_LANG_EDITION
  • CARGO_PKG_LANGUAGE_EDITION
  • ...?

@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2024
@nyurik nyurik force-pushed the pkg-lang-edition branch 2 times, most recently from 93f08b6 to a759287 Compare November 29, 2024 22:06
@epage
Copy link
Contributor

epage commented Nov 29, 2024

As a heads up, our contribution process asks that issues be accepted before moving on to PRs. There are two directions to go and this direction has non-obvious problems to work through. We should work through this first before looking at the implementation.

@nyurik nyurik mentioned this pull request Nov 30, 2024
Open
@bors
Copy link
Contributor

bors commented Dec 6, 2024

☔ The latest upstream changes (presumably 2560340) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2024

☔ The latest upstream changes (possibly 081d7ba) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epage epage

Labels
A-build-execution Area: anything dealing with executing the compiler A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export CARGO_PKG_EDITION variable to build environment
4 participants
@nyurik @rustbot @epage @bors