Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
I was reading the docs to see how to specify a version to use from a git dependency, and came across this section and got really confused as I did not know what
N.B.
meant so the following did not read well for me:N.B. that if ...
. I had to look it up and then realized that I had wasted time that did not need to be wasted. Thus this PR aims to prevent the time of future readers from being wasted.How should we test and review this PR?
Try to read aloud the old version and the new one, as well as the given alternatives to see which would make most sense to the largest number of people.
Additional information
A simple fix would be to just remove "that" as this reads better:
N.B. if a version doesn't match, Cargo will fail to compile!
Other variations
Note that if a version doesn't match, Cargo will fail to compile!
Notice that if a version doesn't match, Cargo will fail to compile!
The role of the version key
section above which clearly states: