Don't link build scripts dynamically #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+
And even if there was, build scripts are transient anyway. |
|
📌 Commit 2116f81 has been approved by |
|
⌛ Testing commit 2116f81 with merge 02b5bb9... |
|
💔 Test failed - cargo-win-msvc-32 |
|
That is such a weird build failure. However I am glad that dojob is doing its job of cleaning up all the zombies. |
There's no real reason to eagerly link build scripts dynamically as they're not going to benefit that much from dynamic linking. Most of the time they only have one dynamic dependency, libstd, and most other Rust programs don't link it dynamically so there's not really many space savings either.
alexcrichton
force-pushed
the
build-static
branch
from
2116f81
to
13d5094
Compare
bors
added a commit
that referenced
this pull request
Sep 1, 2015
There's no real reason to eagerly link build scripts dynamically as they're not going to benefit that much from dynamic linking. Most of the time they only have one dynamic dependency, libstd, and most other Rust programs don't link it dynamically so there's not really many space savings either.
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no real reason to eagerly link build scripts dynamically as they're not
going to benefit that much from dynamic linking. Most of the time they only have
one dynamic dependency, libstd, and most other Rust programs don't link it
dynamically so there's not really many space savings either.