Commits on Nov 28, 2016

1. Test for bad path overrides with summaries …

   Bad path overrides are currently detected to issue warnings in cases where path
   overrides are not suitable and have exhibited buggy behavior in the past.
   Unfortunately though it looks like some false positives are being issued,
   causing unnecessary confusion about `paths` overrides.
   
   This commit fixes the detection of these "bad path overrides" by comparing
   `Summary` dependencies (what's written down in `Cargo.toml`) rather than
   comparing the `Cargo.toml` of the override with `Cargo.lock`. We're guaranteed
   that the package we're overridding has already been resolved into `Cargo.lock`,
   so we know that if the two `Cargo.toml` files are equivalent we'll continue
   with the same crate graph.
   
   I'm not actually entirely sure why I originally thought it'd be better to go
   through the `Cargo.lock` comparison route. Unfortunately that doesn't take into
   account optional deps which aren't in `Cargo.lock` but are in `Cargo.toml` of
   the override, causing the false positive. This method, however, simply ensures
   that the two dependency lists are the same.
   
   Closes rust-lang#3313

   

   alexcrichton committed Nov 28, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 772e1a1
   • Browse repository at this point

   Copy the full SHA

   772e1a1 View commit details

   Browse the repository at this point in the history