ensure libressl compatibility #3644
Conversation
Update libgit2-sys, openssl-sys and openssl as the versions currently in Cargo.lock are not compatible with libressl. Also update tests accordingly Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Looks like there's a failing test: https://ci.appveyor.com/project/rust-lang-libs/cargo/build/1.0.1090/job/e46hxokw069u5kc8 |
|
The failing test is really awkward and looks like a problem on the appveyor side somehow. This seems to be the only place where User-Agent is constructed in libgit2 and the commit that changes form Git/1.0 to Git/2.0 doesn't make it conditionally: libgit2/libgit2@fafafb1f37 (this commit is part of libgit2-sys 0.6.6). It's rather suspicious that out of 4 tests on appveyor, 1 gets that weir error and the 3 others consider that nothing needs actual testing, isn't it? |
|
The three other entries in the AppVeyor matrix are skipped for PRs, which is why they passed. We'll need to update this PR somehow to allow it to land by passing tests on AppVeyor |
|
Ok, I actually found the problem, alongside "http.c" in libgit2 there is a "winhttp.c" which has the 1.0 in it. |
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
|
@bors: r+ |
|
📌 Commit 2096c95 has been approved by |
ensure libressl compatibility It looks like master still isn't compatible with libressl. With this patch it builds and runs fine and all tests pass here.
|
Is there a way to get this backported as well? Should I open other pull requests for the other branches? |
|
Sure yeah, you can just send a PR to the rust-1.16.0 branch |
|
☀️ Test successful - status-appveyor, status-travis |
ensure libressl compatibility like #3644 but for the rust-1.16.0 branch
It looks like master still isn't compatible with libressl.
With this patch it builds and runs fine and all tests pass here.