Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write stderr output from build-scripts next to stdout output #4088

Merged
merged 2 commits into from
May 24, 2017

Conversation

Nemikolh
Copy link
Contributor

Closes #3462.

Please let me know if you want to change the file name for the error output. I originally thought that stdout and stderr would have been nice but I'm worried that changing output to stdout would cause breakage. So I choose the more conservative route.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Thanks

@bors
Copy link
Contributor

bors commented May 24, 2017

📌 Commit 8fa39fc has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 24, 2017

⌛ Testing commit 8fa39fc with merge a45d4e9...

bors added a commit that referenced this pull request May 24, 2017
Write stderr output from build-scripts next to stdout output

Closes #3462.

Please let me know if you want to change the file name for the error output. I originally thought that `stdout` and `stderr` would have been nice but I'm worried that changing `output` to `stdout` would cause breakage. So I choose the more conservative route.
@bors
Copy link
Contributor

bors commented May 24, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a45d4e9 to master...

@bors bors merged commit 8fa39fc into rust-lang:master May 24, 2017
@bors bors mentioned this pull request May 24, 2017
@Nemikolh Nemikolh deleted the buildscript-stderr branch May 24, 2017 18:21
@ehuss ehuss added this to the 1.19.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stderr from build script still does not get saved anywhere
6 participants