Drop rustc-serialize dependency #4149
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
💯 @bors: r+ Thanks so much! |
|
📌 Commit 0973ae8 has been approved by |
Drop rustc-serialize dependency Fixes #3944.
|
💔 Test failed - status-travis |
| #[derive(RustcDecodable)] | ||
| pub struct Options; | ||
| #[derive(Deserialize)] | ||
| pub struct Options {} |
There was a problem hiding this comment.
Docopt currently doesn't support unit structs, as a workaround I changed it to empty struct.
|
@alexcrichton Should we wait for new docopt release with fix or is it ok to use suggested workaround? |
|
@bors: r+ Nah the workaround sounds fine by me! |
|
📌 Commit 10373f4 has been approved by |
Drop rustc-serialize dependency Fixes #3944.
|
💔 Test failed - status-appveyor |
|
@bors: retry |
Drop rustc-serialize dependency Fixes #3944.
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #3944.