Make test less brittle prior to assert_eq failure message format change #4181
Conversation
PR #42541 on Rust is to make assert_eq error message be multi-line. Before implementing this we need to make the current test less brittle.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks for the pr! Looks like some tests are failing though? |
|
@alexcrichton sorry for the wait, have just switched to a new computer and turned 40. Build looks greener. |
|
@bors: r+ |
|
📌 Commit 9569106 has been approved by |
|
Thanks! |
Make test less brittle prior to assert_eq failure message format change PR required for rust-lang/rust#42541 to make assert_eq error message be multi-line. Before implementing this we need to make the current test less brittle. Not 100% clear on if I need the final [...] or not.
|
☀️ Test successful - status-appveyor, status-travis |
|
Going to reopen as test.rs is another example. |
Multiline assert Found a second location where multiline assert_eq failure breaks a test. This is an extention of #4181.
PR required for rust-lang/rust#42541 to make assert_eq error message be multi-line. Before implementing this we need to make the current test less brittle.
Not 100% clear on if I need the final [...] or not.