-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credentials for multiple hosts. #4206
Conversation
Now `cargo login` stores a token per host. If the host parameter is omitted cargo stores a token as default, i.e. as a token for crates.io.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This seems related to #4208 where the choice of url here is not the best today (e.g. the index everywhere) but rather we should find a better identifier for this. In that sense this may not be able to land for awhile unfortunately :( |
Let me know when I can update this PR accordingly to a new identifier. |
☔ The latest upstream changes (presumably #4433) made this pull request unmergeable. Please resolve the merge conflicts. |
It would also occasionally be useful to read Also, note that (at least unless I am misunderstanding the code), the set of places where |
This split is really desired. |
Normally it should. That still does not explain why it must. |
This PR is kind of stale at this point and needs further changes as discussed, so I'm going to close it. Please open a new PR for updated changes! Thank you! |
Support login tokens for multiple registries This pull request builds on #4206 to support login using the the registry from alternate registries (RFC 2141). This includes the following changes: - allow credentials to be stored based on the registry - allow passing the registry to run cargo commands against using --registry Note that this does not include a feature gate on the use of --registry as the publish code blocks publish if we use any features. @alexcrichton, are you happy with this approach, or is there a way that you would recommend this should be relaxed for testing purposes?
☔ The latest upstream changes (presumably #5907) made this pull request unmergeable. Please resolve the merge conflicts. |
Now
cargo login
stores a token per host.If the host parameter is omitted cargo stores a token as default, i.e. as a token for crates.io.
Resolves #3365.
Implemented based on the conversation in #3978.
This RP could be postponed until the cargo team decides which format for registry we should use. Currently, it's a URL.