-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for publish to optionally take the index that can be used #4568
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
345c03d
Add support for publish to take a registry that should be used.
cswindle 4f08943
Merge branch 'master' into alt-registry-publish
cswindle 77ca377
Merge remote-tracking branch 'upstream/master' into alt-registry-publish
cswindle 941d780
Merge branch 'registry-login' into alt-registry-publish-wip
cswindle caf7681
Switch over to use --registry for publish list.
cswindle c86a7bc
Add feature gate on publish field changes.
cswindle 8714f5f
Merge remote-tracking branch 'upstream/master' into alt-registry-publ…
cswindle ef4a920
Include registry in dependencies in the index.
cswindle cb01e03
Use the correct interface for creating an alternative registry source…
cswindle 93c0d7c
Code review markups.
cswindle 4a302ac
Sort out bug with updating registry on a clean build.
cswindle cb37d33
Code review markups.
cswindle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Switch over to use --registry for publish list.
- Loading branch information
commit caf7681fe2f7c28f0d3e1e9efca03739da4d7a51
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this could be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work as if there are allowed registries setup, but we have not provided --registry then we also need to block. This covers the case of pushing to crates.io when publish is set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er so what I mostly mean here is getting rid of the
is_none
+clone
+unwrap
, basically restructuring this to avoid all the function calls (and make it a little easier to read)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have got rid of the is_none, unwrap etc.