Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cargo install --version as well (preferred) #4637

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Allow cargo install --version as well (preferred) #4637

merged 2 commits into from
Oct 19, 2017

Conversation

kivikakk
Copy link
Contributor

Fixes #4590.

The usage looks pretty ugly with this extra line in it, but it's not really avoidable with our docopt use.

We fail if both are provided; accepting both feels like a path to demons.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Oct 18, 2017

📌 Commit 0cbfb67 has been approved by alexcrichton

@alexcrichton alexcrichton added the relnotes Release-note worthy label Oct 18, 2017
@kivikakk
Copy link
Contributor Author

I think we might need to ask bors to repeat the AppVeyor build; looks like a transient 503 while prepping the build environment.

@bors
Copy link
Contributor

bors commented Oct 19, 2017

⌛ Testing commit 0cbfb67 with merge 75f8541...

bors added a commit that referenced this pull request Oct 19, 2017
Allow cargo install --version as well (preferred)

Fixes #4590.

The usage looks pretty ugly with this extra line in it, but it's not really avoidable with our docopt use.

We fail if both are provided; accepting both feels like a path to demons.
@bors
Copy link
Contributor

bors commented Oct 19, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 75f8541 to master...

@bors bors merged commit 0cbfb67 into rust-lang:master Oct 19, 2017
@kivikakk kivikakk deleted the vers-version branch October 19, 2017 07:21
@ehuss ehuss added this to the 1.23.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Release-note worthy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo install should accept --version (in addition to --vers?)
6 participants