Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on more platforms #4713

Merged
merged 1 commit into from
Nov 12, 2017
Merged

Conversation

alexcrichton
Copy link
Member

No description provided.

@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@matklad
Copy link
Member

matklad commented Nov 12, 2017

bors r+

@matklad
Copy link
Member

matklad commented Nov 12, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Nov 12, 2017

📌 Commit 51e5899 has been approved by matklad

@kennytm
Copy link
Member

kennytm commented Nov 12, 2017

The BSDs do have TIOCGWINSZ. The constants are just defined as c_int on some platforms and c_ulong on others. The error on rust-lang/rust#45692 is actually about rust-lang/libc#704.

@alexcrichton
Copy link
Member Author

@kennytm yeah I just didn't want to deal with all the portability stuff here, for me it was easier to just ignore on other platforms as it's a new feature anyway.

bors added a commit that referenced this pull request Nov 12, 2017
Fix compilation on more platforms
@bors
Copy link
Contributor

bors commented Nov 12, 2017

⌛ Testing commit 51e5899 with merge e945a90...

@bors
Copy link
Contributor

bors commented Nov 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing e945a90 to master...

@bors bors merged commit 51e5899 into rust-lang:master Nov 12, 2017
@alexcrichton alexcrichton deleted the fix-bsd branch December 18, 2017 19:47
@ehuss ehuss added this to the 1.23.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants