Switch to using --edition

[dwijnand]

Fixes #5406

[rust-highfive]

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

[matklad]

@bors r+

Thanks!

[bors]

📌 Commit 616ac18 has been approved by matklad

[bors]

⌛ Testing commit 616ac18 with merge 2ca7604b344bb7ef81df0dba20324d9bb03cbf16...

[bors]

💔 Test failed - status-travis

[dwijnand]

looks like even though rust-lang/rust#50080 landed 2 days ago there's no nightly doesn't include it?

just updated my local nightly and it's from 4 days ago - is this normal?

$ rustc +nightly --version
rustc 1.27.0-nightly (ac3c2288f 2018-04-18)

[matklad]

Yep, nightlies are produced only when RLS and rustfmt work, and that is not always the case

[dwijnand]

Ah, I see! is there a dashboard or log somewhere to track/see that?

[matklad]

I don’t know, I just rustup update nightly to check.

Closing in favor of #5410:)

[dwijnand]

uhh....

:(

[dwijnand]

following the same spirit as this comment I don't understand why my PR was closed in favour of an almost identical one opened hours after mine.

it's not a major issue, particularly with a 3 line PR, but maybe it's even better to be mentioned in this trivial case instead of in a more important, large PR.

[matklad]

The two PRs indeed were almost identical, so at least one of them had to be closed. There’s no real reason to prefer one to the other, so I’ve picked the other one for semi-arbitrary reason that it changed comments to not refer to the Z flag.

It’s the nature of loselelly coordinated open source projects that duplicate or contradictory work sometimes happen, I’ve been there myself :(

[dwijnand]

Btw I had considered the comment. I'm not expert on rustc options, but the -Zedition to --edition moved seemed to me to be about it going from being unstable to stable, and therefore I wondered if the comment should be amended, or even scrapped. Simply replacing -Zedition with --edition in the comment I perceived to be the worst option as it probably made the comment "more wrong" than just leaving it as is. It was something I expected to discuss with someone with better knowledge and foresight than myself.

About more general coordination and collaboration efforts on GitHub I recently found out (perhaps in this update) that you can create GitHub teams with (just) read access to repos, and by doing so you can assign issues to those team members. Could be useful to setup (here or elsewhere).

[ehuss]

Ah, I see! is there a dashboard or log somewhere to track/see that?

The dashboard is here: https://rust-lang-nursery.github.io/rust-toolstate/

[dwijnand]

thank you! I also found in the playground you can see the timestamp of nightly, assuming it's kept fairly up-to-date.