FIx false positive warning #5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ |
|
📌 Commit fbd29f6 has been approved by |
|
⌛ Testing commit fbd29f621b4dadbc457dae4ffe9335a47c29619f with merge 870afba9143665984a461e26d0c327250b7f306b... |
We warn if a feature was specified corresponding to a dependency which is not optional. However, a dependency can be both optional and required, and we shouldn't warn in that case.
|
@bors r=alexcrhiton |
|
📌 Commit 739cc20 has been approved by |
bors
added a commit
that referenced
this pull request
May 5, 2018
FIx false positive warning We warn if a feature was specified corresponding to a dependency which is not optional. However, a dependency can be both optional and required, and we shouldn't warn in that case. cc #5480 r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We warn if a feature was specified corresponding to a dependency which
is not optional. However, a dependency can be both optional and
required, and we shouldn't warn in that case.
cc #5480
r? @alexcrichton