Always replace metadata when replacing package

[mati865]

Fixes #4582

I'm having problem writing test for it.
The test should install binary, make commit and reinstall binary, this part is done.
To know if it was done properly we need to compare git revision of HEAD and installed binary and that's where the problems begin...

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[alexcrichton]

Perhaps the manifest file could be manually read here to assert that the updated revision is reflected there?

[mati865]

I'm not familiar with cargo code base. I came here because of nabijaczleweli/cargo-update#55 to be honest.

Could you point me where should I start searching?

[alexcrichton]

Ah no worries! In the tests I believe you can use paths::home and std::fs to read the crate manifest and basically just assert that the revision you expected is located within the manifest

[mati865]

I thought about cargo function parsing .crates.toml but yeah you solution should be simpler.

[mati865]

Updated test does fail for non patched code and succeeds with fix applied.

[alexcrichton]

@bors: r+

Thanks!

[bors]

📌 Commit 059107e has been approved by alexcrichton

[bors]

⌛ Testing commit 059107e with merge 4c8b8ac...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 4c8b8ac to master...

[mati865]

Thanks 👍
When it would be appropriative to update cargo submodule for rust again?
It's just a small QoL improvement for cargo-update users but last update was 9 days ago anyway.
I can open PR if you wish.

[alexcrichton]

Certainly! A PR any time is fine, it's done on an as-needed basis

[mati865]

Opened rust-lang/rust#51062