Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metabuild (RFC 2196) #5628

Merged
merged 4 commits into from
Aug 24, 2018
Merged

Metabuild (RFC 2196) #5628

merged 4 commits into from
Aug 24, 2018

Commits on Aug 23, 2018

  1. Metabuild (RFC 2196)

    ehuss committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    2be857a View commit details
    Browse the repository at this point in the history
  2. Address review comments.

    - Add newline at end of file.
    - Remove unnecessary rustfmt changes.
    - Move file writing code to `write_if_changed`.
    ehuss committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    ae5e845 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary change.

    ehuss committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    e685bbf View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2018

  1. New metabuild strategy using custom src_path enum.

    - Use new enum `TargertSourcePath` for Target::src_path to make it explicit that metabuild has a special path.
    - `cargo metadata` now skips the metabuild Target.
    - JSON artifacts include the true path to the metabuild source file. This may not be the best solution, but it's unclear what it should be, and I would prefer to avoid breaking the output. Alternatively it could just not emit anything? I'm not completely familiar with the use case of these artifact messages.
    - Place the file in `target/.metabuild/metabuild-pkgname-HASH.rs` instead of in the debug/release directory.  Its contents do not depend on the profile.
    - Fix bug in write_if_changed.
    - More tests.
    ehuss committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    ecc87b1 View commit details
    Browse the repository at this point in the history