-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verbose update of dependencies #5634
Conversation
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
||
{ | ||
let dependents_iter = changes.iter() | ||
.filter(|(_, v)| v.0.len() == 0 && v.1.len() == 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is one edge case where this check is not enough, e.g.
- Set up a workspace with the following members and dependencies:
a → bitflags="0.9"
b → bitflags="1.0"
c → bitflags="0.9"
cargo update
to build the lock file- New version of bitflags is released on crates.io -
1.x
- Edit
c
's version of bitflags to1.0
cargo update
will print only the message describing an update from1.0
to1.x
In the second commit, I completely refactored the way diffs are generated. Yet, the output is consistent with the output cargo produces currently. diff of |
But I am not sure if #5530 and this pr is valid in general. Before:
Now
If the new assumptions are valid, than the issue and this pr are valid as well |
Thanks for the PR! I definitely think that #5530 is a good issue to fix in that Mind adding a few tests for the fixed cases here as well? Other than that looks good to go to me! |
ping @debris, have you had a chance to take another look at this? |
sure, I'll try to finish this in the upcoming week |
Ok I'm gonna close this for now, but @debris if you get a chance to update I can certainly reopen! |
In some cases (#5530) cargo does not print update messages. This pr tries to address this problem.
In a case described in issue #5530, cargo will print additional line:
Updating registry `https://github.com/rust-lang/crates.io-index` + Updating bitflags v0.9.1 -> v1.0.3
If accepted, I will add some tests